Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored fallback logic to only patch status when the fallback is e… #5659

Merged
merged 19 commits into from
Aug 2, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP: verifying test failure fixes
Signed-off-by: Bharath Guvvala <bharath.raghavendra@gmail.com>
  • Loading branch information
bharathguvvala committed Apr 11, 2024
commit 10fb40f8a42e59def1913f535f209cc1bd1a22f0
2 changes: 1 addition & 1 deletion pkg/fallback/fallback_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ func (h *healthStatusMatcher) NegatedFailureMessage(actual interface{}) (message

func expectStatusPatch(ctrl *gomock.Controller, client *mock_client.MockClient) {
statusWriter := mock_client.NewMockStatusWriter(ctrl)
statusWriter.EXPECT().Patch(gomock.Any(), gomock.Any(), gomock.Any())
//statusWriter.EXPECT().Patch(gomock.Any(), gomock.Any(), gomock.Any())
client.EXPECT().Status().Return(statusWriter)
}

Expand Down
Loading