Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm chart uses outdated API version for ingress and should support ingressClassName #635

Closed
brianmay opened this issue Sep 8, 2021 · 0 comments · Fixed by #636
Closed

Comments

@brianmay
Copy link
Contributor

brianmay commented Sep 8, 2021

W0909 09:08:48.099861  299554 warnings.go:70] extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
W0909 09:08:48.128581  299554 warnings.go:70] extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
W0909 09:08:48.245069  299554 warnings.go:70] extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress

This is from:

# Source: keel/charts/keel/templates/ingress.yaml
apiVersion: extensions/v1beta1

Also it looks like the ingress chart doesn't support the ingressClassName which is required for ingress-nginx 4.0

https://kubernetes.io/blog/2020/04/02/improvements-to-the-ingress-api-in-kubernetes-1.18/#deprecating-the-ingress-class-annotation

Here is the change that is required to do that:

https://github.com/longhorn/longhorn/pull/2258/files

brianmay added a commit to brianmay/keel that referenced this issue Sep 14, 2021
brianmay added a commit to brianmay/keel that referenced this issue Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant