Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ingress chart definition #636

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

brianmay
Copy link
Contributor

Closes #635

@brianmay
Copy link
Contributor Author

If there is anything else I need to change release, please let me know.

@brianmay
Copy link
Contributor Author

The lint check seemed to require I update the chart version, so I did that.

@NicolasLemince
Copy link
Contributor

@rusenask can we merge ? It is an essential update...

@rusenask
Copy link
Collaborator

rusenask commented Nov 3, 2021

yes, sorry for the delay!

@rusenask rusenask merged commit 74a5f3b into keel-hq:master Nov 3, 2021
gerhard added a commit to thechangelog/changelog.com that referenced this pull request Jan 17, 2022
There is no version currently released that has this fix in:
keel-hq/keel#636

This is good enough for now, but it's a reminder that we are doing
GitOps wrong, and we should cover the last 10%. Any day now...

Next: changelog, the app!

Signed-off-by: Gerhard Lazu <gerhard@lazu.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

helm chart uses outdated API version for ingress and should support ingressClassName
3 participants