Handling the "unnecessary await" linter warning #1177

jaybuidl · 2023-08-22T09:41:03Z

The initial goal of this PR was to remove some await because of this:

https://codeclimate.com/github/kleros/kleros-v2/web/src/hooks/queries/useCounter.ts?from_sha=d01a8886&to_sha=c04e8c78

Looking further into, ESLint has deprecated the no-return-await rule:

This rule was deprecated in ESLint v8.46.0 with no replacement. The original intent of this rule no longer applies due to the fact JavaScript now handles native Promises differently. It can now be slower to remove await rather than keeping it. More technical information can be found in this V8 blog entry.

It turns out that there is a tradeoff between a potentially small perf improvement (without await, but it encourages bad dev habits) vs better stack traces in the V8 engine only (with await).

This additional rule @typescript-eslint/return-await provides more granularity

This rule builds on top of the eslint/no-return-await rule. It expands upon the base rule to add support for optionally requiring return await in certain cases.

netlify · 2023-08-22T09:41:08Z

✅ Deploy Preview for kleros-v2 ready!

Name	Link
🔨 Latest commit	`cc905b0`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2/deploys/64e4938192eceb00082dd1fa
😎 Deploy Preview	https://deploy-preview-1177--kleros-v2.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2023-08-22T09:41:09Z

✅ Deploy Preview for kleros-v2-contracts ready!

Name	Link
🔨 Latest commit	`cc905b0`
🔍 Latest deploy log	https://app.netlify.com/sites/kleros-v2-contracts/deploys/64e49381f1cdb800080c3bcc
😎 Deploy Preview	https://deploy-preview-1177--kleros-v2-contracts.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.