Handling the "unnecessary await" linter warning

.codeclimate.yml

@@ -4,5 +4,17 @@ engines:
     checks:
       quotemark:
         enabled: false
+  eslint:
+    enabled: true
+    config:
+      config:
+      - web/.eslintrc.json
+      - eslint-config/.eslintrc.js
+      extensions:
+      - .es6
+      - .js
+      - .jsx
+      - .mjs
+      - .vue
 exclude_paths:
   - "web/src/graphql/generated.ts"

eslint-config/.eslintrc.js

@@ -10,13 +10,23 @@ module.exports = {
     mocha: true,
     es2020: true,
   },
-  extends: [
-    "eslint:recommended",
-    "plugin:@typescript-eslint/recommended",
-    "plugin:prettier/recommended",
-    "plugin:import/recommended",
-  ],
+  extends: ["eslint:recommended", "plugin:prettier/recommended", "plugin:import/recommended"],
   plugins: ["@typescript-eslint", "prettier", "import"],
+  overrides: [
+    {
+      files: ["*.ts", "*.tsx"],
+      extends: [
+        "plugin:@typescript-eslint/recommended",
+        "plugin:@typescript-eslint/recommended-requiring-type-checking",
+      ],
+      parserOptions: {
+        project: ["./tsconfig.json"],
+      },
+      rules: {
+        "@typescript-eslint/return-await": ["error", "always"],
+      },
+    },
+  ],
   rules: {
     "no-unused-vars": [
       "error",
@@ -44,5 +54,6 @@ module.exports = {
         tryExtensions: [".js", ".ts", ".json", ".node"],
       },
     ],
+    "no-return-await": "off",
   },
 };

eslint-config/package.json

@@ -18,7 +18,7 @@
     "eslint-utils": "^3.0.0"
   },
   "devDependencies": {
-    "typescript": "^4.9.5"
+    "@kleros/kleros-v2-tsconfig": "*"
   },
   "peerDependencies": {
     "eslint": "8.x"

web/.eslintignore

@@ -0,0 +1 @@
+src/hooks/contracts/generated.ts

web/.eslintrc.json

@@ -34,6 +34,29 @@
     "security",
     "import"
   ],
+  "overrides": [
+    {
+      "files": [
+        "*.ts",
+        "*.tsx"
+      ],
+      "extends": [
+        "plugin:@typescript-eslint/recommended",
+        "plugin:@typescript-eslint/recommended-requiring-type-checking"
+      ],
+      "parserOptions": {
+        "project": [
+          "./tsconfig.json"
+        ]
+      },
+      "rules": {
+        "@typescript-eslint/return-await": [
+          "error",
+          "always"
+        ]
+      }
+    }
+  ],
   "ignorePatterns": [
     "src/assets"
   ],
@@ -83,6 +106,7 @@
         ]
       }
     ],
+    "no-return-await": "off",
     "@typescript-eslint/no-non-null-assertion": "off",
     "@typescript-eslint/no-explicit-any": "off",
     "security/detect-object-injection": "off",

yarn.lock

@@ -5197,6 +5197,7 @@ __metadata:
   version: 0.0.0-use.local
   resolution: "@kleros/kleros-v2-eslint-config@workspace:eslint-config"
   dependencies:
+    "@kleros/kleros-v2-tsconfig": "*"
     "@typescript-eslint/eslint-plugin": ^5.59.11
     "@typescript-eslint/parser": ^5.61.0
     "@typescript-eslint/utils": ^5.59.11
@@ -5208,7 +5209,6 @@ __metadata:
     eslint-plugin-promise: ^5.2.0
     eslint-plugin-security: ^1.7.1
     eslint-utils: ^3.0.0
-    typescript: ^4.9.5
   peerDependencies:
     eslint: 8.x
   languageName: unknown
@@ -5236,7 +5236,7 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@kleros/kleros-v2-tsconfig@workspace:^, @kleros/kleros-v2-tsconfig@workspace:tsconfig":
+"@kleros/kleros-v2-tsconfig@*, @kleros/kleros-v2-tsconfig@workspace:^, @kleros/kleros-v2-tsconfig@workspace:tsconfig":
   version: 0.0.0-use.local
   resolution: "@kleros/kleros-v2-tsconfig@workspace:tsconfig"
   dependencies: