-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Signing modal consistency #9002
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request introduces a new signing modal feature in various components including creating NFTs, creating collections, buying NFTs, bridging the currency, transferring NFTs, minting generative drops and burning NFTs. The patches also update the related language locales to accommodate the changes brought in by the new signing modal. Additionally, there are several changes relating to replacements of the Loader component with the SigningModal component. The settings for the SigningModal have been specified according to each particular use case. The patches also involve the introduction of new language keys and small fixes to ensure the setting of properties fits the business rules correctly. |
…into issue-8904
CleanShot.2024-01-20.at.17.11.01.mp4@roiLeo @preschian added try again feature , review again if needed
@exezbcz was not added, pls try now |
Code Climate has analyzed commit c9df787 and detected 0 issues on this pull request. View more on Code Climate. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
we can hold this one for this week release as it's not well tested and we don't want to break something. |
I think it's over drop and we can push it to beta so we can collectively test out Otherwise it would needs consistently maintain conflicts Agree? |
Thanks! |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
PR Type
Context
new signing modal added to:
Needs Design check
Did your issue had any of the "$" label on it?
Screenshot 📸