-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Inner box in loading modal #9138
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request includes changes to two Vue.js components: SkeletonLoader.vue and ModalBody.vue. The change in SkeletonLoader.vue involved adding an ID to the NeoSkeleton element in the template. In ModalBody.vue, there has been a refactor to the modal skeleton's CSS style rules. Instead of applying the styling rules to the '.skeleton-backdrop' class, the style is now applied to the '#skeleton-backdrop' ID, which can improve the specificity of the selector. There has been a slight code reduction because of the removal of nested style rules. The original behavior regarding the position, dimensions, and maximum height of the modal skeleton is maintained. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Code Climate has analyzed commit 666c166 and detected 0 issues on this pull request. View more on Code Climate. |
already fixed by #9002 |
PR Type
Context
Needs Design check
Did your issue had any of the "$" label on it?
Screenshot 📸