Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Inner box in loading modal #9138

Closed
wants to merge 2 commits into from
Closed

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Jan 26, 2024

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Needs Design check

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2024-01-26 at 06 39 47@2x

@hassnian hassnian requested a review from a team as a code owner January 26, 2024 01:39
@hassnian hassnian requested review from preschian and roiLeo and removed request for a team January 26, 2024 01:39
Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 666c166
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65b4e5c661075f00083a34ed
😎 Deploy Preview https://deploy-preview-9138--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Jan 26, 2024

WARNING @hassnian PR for issue #9137 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #9137

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jan 26, 2024
Copy link
Contributor

reviewpad bot commented Jan 26, 2024

AI-Generated Summary: This pull request includes changes to two Vue.js components: SkeletonLoader.vue and ModalBody.vue. The change in SkeletonLoader.vue involved adding an ID to the NeoSkeleton element in the template. In ModalBody.vue, there has been a refactor to the modal skeleton's CSS style rules. Instead of applying the styling rules to the '.skeleton-backdrop' class, the style is now applied to the '#skeleton-backdrop' ID, which can improve the specificity of the selector. There has been a slight code reduction because of the removal of nested style rules. The original behavior regarding the position, dimensions, and maximum height of the modal skeleton is maintained.

Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Jan 26, 2024
@reviewpad reviewpad bot added the docs label Jan 27, 2024
Copy link

sonarcloud bot commented Jan 27, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codeclimate bot commented Jan 27, 2024

Code Climate has analyzed commit 666c166 and detected 0 issues on this pull request.

View more on Code Climate.

@hassnian
Copy link
Contributor Author

already fixed by #9002

@hassnian hassnian closed this Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-resolve-merge-conflicts-🤝 S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inner box in loading modal
6 participants