Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Make sure that all binaries are in correct locations across all providers in the images #474

Closed
1 task done
shawn-hurley opened this issue Jan 24, 2024 · 1 comment · Fixed by #556
Closed
1 task done
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Milestone

Comments

@shawn-hurley
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

0.3.0

Priority

Critical

Current Behavior

We have binaries all over the place, as we move to external providers, we want to make sure that we have know location for all of this.

Expected Behavior

A non-root dir (probably /usr/local/bin) should be the location for all the binaries.

We need to update all configs to use the correct locations.

How Reproducible

Always (Default)

Steps To Reproduce

look at the docker file

Environment

- **Analyzer Image SHA** 
- **JDTLS  base image SHA**
- **Provider Settings JSON**

Anything else?

No response

@shawn-hurley shawn-hurley added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 24, 2024
@shawn-hurley shawn-hurley added this to the Next milestone Jan 24, 2024
@shawn-hurley shawn-hurley added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Jan 24, 2024
@pranavgaikwad pranavgaikwad removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 25, 2024
@pranavgaikwad pranavgaikwad modified the milestones: Next, v0.3.1 Jan 25, 2024
@pranavgaikwad pranavgaikwad self-assigned this Feb 9, 2024
@shawn-hurley
Copy link
Contributor Author

I believe that for all the external providers that exist today all the binaries are in /usr/bin

I don't believe that we should fix this in a Z-stream, because we would need to update both Kantra and the hub on these values.

I am going to push this to 0.4 and get a PR up to move things to /usr/local/bin.

This is only for the external plugins; Java is still going to be a special case and is still going to have to be ripped out as part of the work that @eemcmullan is doing. I don' think that we should tackle that with this bug.

@shawn-hurley shawn-hurley modified the milestones: v0.3.1, v0.4.0 Mar 19, 2024
shawn-hurley added a commit that referenced this issue Mar 27, 2024
fixes #474

Addon PR: 80

Signed-off-by: Shawn Hurley <shawn@hurley.page>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
Status: Done
Status: ✅ Done
2 participants