👻 Improve running as non-root #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmontleon
force-pushed
the
improve-non-root
branch
from
94e76a7
to
c7acfa5
Compare
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
jmontleon
force-pushed
the
improve-non-root
branch
from
c7acfa5
to
880b2aa
Compare
shawn-hurley
approved these changes
Jan 24, 2024
|
follow up issue created in #474 |
shawn-hurley
added
the
cherry-pick/release-0.3
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
With this change we can at least run as non-root. I would also proprose moving binaries that need to be accessible to all users be installed in /usr/local/bin. But as of right now it seems we have configs (or something) hard coded to this location. https://github.com/konveyor/java-analyzer-bundle/blob/main/Dockerfile#L41 https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s09.html Signed-off-by: Jason Montleon <jmontleo@redhat.com>
pranavgaikwad
pushed a commit
that referenced
this pull request
Jan 25, 2024
With this change we can at least run as non-root. I would also proprose moving binaries that need to be accessible to all users be installed in /usr/local/bin. But as of right now it seems we have configs (or something) hard coded to this location. https://github.com/konveyor/java-analyzer-bundle/blob/main/Dockerfile#L41 https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s09.html Signed-off-by: Jason Montleon <jmontleo@redhat.com> Signed-off-by: Jason Montleon <jmontleo@redhat.com> Co-authored-by: Jason Montleon <jmontleo@redhat.com>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we can at least run as non-root.
I would also proprose moving binaries that need to be accessible to all users be installed in /usr/local/bin. But as of right now it seems we have configs (or something) hard coded to this location.
https://github.com/konveyor/java-analyzer-bundle/blob/main/Dockerfile#L41
https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch04s09.html