🐛 Update indirect Dependency location #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating dependency incident location lookup for indirect dependencies to point to "parent" dependency location. E.g. for `maven-javax-to-jakarta-00002` rule. Related to https://issues.redhat.com/browse/MTA-2006 Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <maufart@redhat.com>
aufi
changed the title
Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <maufart@redhat.com>
pranavgaikwad
requested changes
Mar 27, 2024
rule-example.yaml
Outdated
| xpath: /b:beans | ||
| - category: potential | ||
| customVariables: [] |
There was a problem hiding this comment.
nit: can we shrink this rule, just keep the required fields for brevity i.e. remove labels, links, customVariables?
| @@ -361,6 +374,19 @@ | |||
| resolvedIdentifier: 7873092d39ef741575ca91378a6a21c388363ac8 | |||
| extras: | |||
| artifactId: logback-core | |||
| baseDep: | |||
| name: ch.qos.logback.logback-classic | |||
There was a problem hiding this comment.
nit: can we produce only the required fields of the baseDep
provider/provider.go
Outdated
| @@ -745,6 +745,15 @@ func (dc DependencyCondition) Evaluate(ctx context.Context, log logr.Logger, con | |||
| if err == nil { | |||
| incident.LineNumber = &location.StartPosition.Line | |||
| incident.CodeLocation = &location | |||
| } else if baseDep, ok := matchedDep.dep.Extras["baseDep"]; ok { | |||
There was a problem hiding this comment.
since I looked into too many perf issues recently :)... maybe we can make only one call to GetLocation based on either direct or base dep?
|
Thanks for review @pranavgaikwad, will update! |
Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <maufart@redhat.com>
Signed-off-by: Marek Aufart <maufart@redhat.com>
pranavgaikwad
approved these changes
Mar 28, 2024
pranavgaikwad
added a commit
that referenced
this pull request
Apr 2, 2024
This reverts commit b4d2369.
Merged
aufi
pushed a commit
that referenced
this pull request
Apr 3, 2024
pranavgaikwad
pushed a commit
to pranavgaikwad/analyzer-lsp
that referenced
this pull request
Apr 8, 2024
pranavgaikwad
added a commit
to pranavgaikwad/analyzer-lsp
that referenced
this pull request
Apr 8, 2024
This slipped through somehow after merging konveyor#351 I should have re-run CI before merging konveyor#557 Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
pranavgaikwad
pushed a commit
to pranavgaikwad/analyzer-lsp
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Marek Aufart <maufart@redhat.com>
pranavgaikwad
added a commit
to pranavgaikwad/analyzer-lsp
that referenced
this pull request
Apr 8, 2024
This slipped through somehow after merging konveyor#351 I should have re-run CI before merging konveyor#557 Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
pranavgaikwad
pushed a commit
to pranavgaikwad/analyzer-lsp
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Marek Aufart <aufi.cz@gmail.com>
pranavgaikwad
added a commit
to pranavgaikwad/analyzer-lsp
that referenced
this pull request
Apr 8, 2024
This slipped through somehow after merging konveyor#351 I should have re-run CI before merging konveyor#557 Signed-off-by: Pranav Gaikwad <pgaikwad@redhat.com>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating dependency incident location lookup for indirect dependencies to point to "parent" dependency location. E.g. for maven-javax-to-jakarta-00002 rule.
Replaces #532
Related to https://issues.redhat.com/browse/MTA-2006