fix(select): "show more" text calculations (#DS-2649) #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit ba472a4): https://koobiq-next--prs-135-i3c5l78k.web.app (expires Sun, 21 Jul 2024 12:15:40 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
artembelik
reviewed
Jul 15, 2024
artembelik
reviewed
Jul 15, 2024
artembelik
approved these changes
Jul 16, 2024
|
@NikGurev давай ограничимся в этом PR простым исправлением без рефакторинга. Задача на вынос общей логики есть (недавно часть директив вынес). Я хочу двигаться в сторону вынесения общей логики в компонент, а не отдельных функций или методов |
artembelik
approved these changes
Jul 16, 2024
lskramarov
approved these changes
Jul 16, 2024
sk8knut
pushed a commit
that referenced
this pull request
Jul 22, 2024
* main: fix(docs): update tokens for disabled radio (#DS-2635) (#146) feat: added prettier support for html, xml files (#DS-2653) (#152) fix(docs): examples, api sections selection and scroll after link opened (#DS-2478) (#148) fix(datepicker, timepicker): lost focus after backspace/delete (#DS-2492) (#145) fix(modal): text in modal title is not cut off (#DS-2430) (#149) feat(docs): updated example code block show (#DS-2602) (#150) feat: added prettier support for json, js, ts files (#DS-2569) (#136) feat(timepicker): placeholder and view value localization (#DS-2059) (#144) fix(docs): example start command change (#DS-2529) (#142) chore: bump version to 17.0.0-rc.10 w/ changelog fix(docs): highlight selected item (#DS-2597) (#137) feat(empty-state): added empty-state (#DS-2572) (#129) fix(docs,toast): single stack of toasts (#DS-2541) (#140) fix(select): "show more" text calculations (#DS-2649) (#135) fix(button): background for filled-contrast-fade-[off/on]-states-disabled-background fix(badge): outline badges borders color (#DS-3640) (#139) fix(docs): fixed Algolia crawler feat: added prettier support for markdown and yaml (#DS-2650) (#133) feat: added prettier support for stylelint (#DS-2568) (#130) feat(docs): theming article rewrite (#DS-2544) (#114) # Conflicts: # packages/components-dev/navbar/template.html # packages/docs-examples/components/navbar/navbar-overview/navbar-overview-example.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed calculcation since flex gap didn't take into count
List of notable changes: