fix(datepicker, timepicker): lost focus after backspace/delete (#DS-2492) #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vitalyozza в datepicker поправил, посмотри пожалуйста. В timepicker правлю, напишу как сделаю. |
|
Visit the preview URL for this PR (updated for commit 4397ae4): https://koobiq-next--prs-145-2boptkvf.web.app (expires Tue, 23 Jul 2024 12:20:10 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
artembelik
approved these changes
Jul 18, 2024
lskramarov
force-pushed
the
bugfix/DS-2492
branch
from
eb5dc96
to
4397ae4
Compare
sk8knut
approved these changes
Jul 18, 2024
NikGurev
approved these changes
Jul 19, 2024
|
@lskramarov посмотрел текущую реализацию, она корректна, думаю, более плавное поведение добьем при обновлении datepicker / timepicker позже, а пока даю добро на текущую реализацию 👌🏻 |
|
@lskramarov проверил Timepicker, все хорошо! |
vitalyozza
approved these changes
Jul 19, 2024
sk8knut
pushed a commit
that referenced
this pull request
Jul 22, 2024
* 'main' of github.com:koobiq/angular-components: fix(docs): examples, api sections selection and scroll after link opened (#DS-2478) (#148) fix(datepicker, timepicker): lost focus after backspace/delete (#DS-2492) (#145) fix(modal): text in modal title is not cut off (#DS-2430) (#149) feat(docs): updated example code block show (#DS-2602) (#150) feat: added prettier support for json, js, ts files (#DS-2569) (#136) feat(timepicker): placeholder and view value localization (#DS-2059) (#144)
sk8knut
pushed a commit
that referenced
this pull request
Jul 22, 2024
* main: fix(docs): update tokens for disabled radio (#DS-2635) (#146) feat: added prettier support for html, xml files (#DS-2653) (#152) fix(docs): examples, api sections selection and scroll after link opened (#DS-2478) (#148) fix(datepicker, timepicker): lost focus after backspace/delete (#DS-2492) (#145) fix(modal): text in modal title is not cut off (#DS-2430) (#149) feat(docs): updated example code block show (#DS-2602) (#150) feat: added prettier support for json, js, ts files (#DS-2569) (#136) feat(timepicker): placeholder and view value localization (#DS-2059) (#144) fix(docs): example start command change (#DS-2529) (#142) chore: bump version to 17.0.0-rc.10 w/ changelog fix(docs): highlight selected item (#DS-2597) (#137) feat(empty-state): added empty-state (#DS-2572) (#129) fix(docs,toast): single stack of toasts (#DS-2541) (#140) fix(select): "show more" text calculations (#DS-2649) (#135) fix(button): background for filled-contrast-fade-[off/on]-states-disabled-background fix(badge): outline badges borders color (#DS-3640) (#139) fix(docs): fixed Algolia crawler feat: added prettier support for markdown and yaml (#DS-2650) (#133) feat: added prettier support for stylelint (#DS-2568) (#130) feat(docs): theming article rewrite (#DS-2544) (#114) # Conflicts: # packages/components-dev/navbar/template.html # packages/docs-examples/components/navbar/navbar-overview/navbar-overview-example.html
sk8knut
added a commit
that referenced
this pull request
Jul 24, 2024
* main: (39 commits) feat: migrated from jasmine/karma to jest (#DS-2192) (#154) feat(docs): added icon-items (#DS-2636) (#155) fix(typography): font-style italic fix (#DS-2671) (#153) chore: fixed version fix(docs): default font (#DS-2648) (#151) chore: bump version to 17.0.0-rc.11 w/ changelog fix(link): alignment of the icon relative to the text (#DS-2690) (#163) feat(docs): welcome page - new images for empty state (#DS-2668) (#156) task(welcome): generic images on welcome page if not image for item (#DS-2669) (#159) fix(dropdown): focused keyboard dropdown items fix (#DS-2665) (#158) fix(radio): radio icon top positions fixed (#DS-2691) (#162) fix(tree-select): localization for hiddenItemsText (#DS-2680) (#157) fix(list): replaced all size/padding tokens with css variables and fi… (#132) fix(sidepanel): fixed sidepanel max width (#DS-2314) (#141) fix(radio): fixed disabled radio styles (#DS-2666) (#143) fix(navbar): fixed navbar dropdown (#DS-2558) (#131) fix(docs): update tokens for disabled radio (#DS-2635) (#146) feat: added prettier support for html, xml files (#DS-2653) (#152) fix(docs): examples, api sections selection and scroll after link opened (#DS-2478) (#148) fix(datepicker, timepicker): lost focus after backspace/delete (#DS-2492) (#145) ... # Conflicts: # packages/docs-examples/components/alert/alert-close/alert-close-example.html # packages/docs-examples/components/alert/alert-content/alert-content-example.html # packages/docs-examples/components/alert/alert-size/alert-size-example.html # packages/docs-examples/components/alert/alert-status/alert-status-example.ts # packages/docs-examples/components/alert/alert-variants/alert-variants-example.html # packages/docs-examples/components/alert/alert-variants/alert-variants-example.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.