Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(empty-state): added empty-state (#DS-2572) #129

Merged
merged 8 commits into from
Jul 17, 2024
Merged

Conversation

lskramarov
Copy link
Contributor

No description provided.

@lskramarov lskramarov self-assigned this Jul 10, 2024
Copy link

github-actions bot commented Jul 10, 2024

Visit the preview URL for this PR (updated for commit 2ebad3c):

https://koobiq-next--prs-129-z3rscpyz.web.app

(expires Sun, 21 Jul 2024 11:16:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@lskramarov lskramarov requested a review from rmnturov July 12, 2024 07:54
@lskramarov
Copy link
Contributor Author

lskramarov commented Jul 12, 2024

@rmnturov так же заметил что:

  1. Отступ у иконки в макетах разный для состояний normal и big, а в токенах одинаковый (32px)
  2. В макетах с примером что то не то:
    chrome_TCx0OAIg6a
  3. Текст у примера с заголовком от примера с иконкой:
    chrome_OiFB4QhPYw
  4. В макетах старые размеры шрифтов, заметил у кнопки 13px

@lskramarov lskramarov marked this pull request as ready for review July 12, 2024 12:33
@NikGurev
Copy link
Contributor

@lskramarov @rmnturov
На главной иллюстрация сломалась

image

@rmnturov
Copy link
Contributor

rmnturov commented Jul 16, 2024

@lskramarov я обновил макеты под новую типографику и исправил токены (шрифты, отступы, разный маргин под картинкой). Поправил пример в доках.

Макеты
https://www.figma.com/design/xzvLO9WNSWB8ESnzQbsMEK/Empty-State-Placeholder?node-id=2026-25006

Пул-реквест на токены
koobiq/design-tokens#22

@lskramarov lskramarov merged commit d0fe7d8 into main Jul 17, 2024
3 checks passed
@lskramarov lskramarov deleted the feat/DS-2572 branch July 17, 2024 08:07
sk8knut pushed a commit that referenced this pull request Jul 22, 2024
* main:
  fix(docs): update tokens for disabled radio (#DS-2635)  (#146)
  feat: added prettier support for html, xml files (#DS-2653) (#152)
  fix(docs): examples, api sections selection and scroll after link opened (#DS-2478) (#148)
  fix(datepicker, timepicker): lost focus after backspace/delete (#DS-2492) (#145)
  fix(modal): text in modal title is not cut off (#DS-2430) (#149)
  feat(docs): updated example code block show (#DS-2602) (#150)
  feat: added prettier support for json, js, ts files (#DS-2569) (#136)
  feat(timepicker): placeholder and view value localization (#DS-2059) (#144)
  fix(docs): example start command change (#DS-2529) (#142)
  chore: bump version to 17.0.0-rc.10 w/ changelog
  fix(docs): highlight selected item (#DS-2597) (#137)
  feat(empty-state): added empty-state (#DS-2572) (#129)
  fix(docs,toast): single stack of toasts (#DS-2541) (#140)
  fix(select): "show more" text calculations (#DS-2649) (#135)
  fix(button): background for filled-contrast-fade-[off/on]-states-disabled-background
  fix(badge): outline badges borders color (#DS-3640)  (#139)
  fix(docs): fixed Algolia crawler
  feat: added prettier support for markdown and yaml (#DS-2650) (#133)
  feat: added prettier support for stylelint (#DS-2568) (#130)
  feat(docs): theming article rewrite (#DS-2544) (#114)

# Conflicts:
#	packages/components-dev/navbar/template.html
#	packages/docs-examples/components/navbar/navbar-overview/navbar-overview-example.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants