Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): updated example code block show (#DS-2602) #150

Merged
merged 4 commits into from
Jul 19, 2024
Merged

Conversation

NikGurev
Copy link
Contributor

Summary

Updated example code block usage.

List of notable changes:

  • If there is only one non-empty document in the example, then show the block without tabs
  • Show a block of code expanded without the ability to collapse after clicking the Show code button in the example. The height of the block depends on the content.

@NikGurev NikGurev added the documentation Improvements or additions to documentation label Jul 18, 2024
@NikGurev NikGurev self-assigned this Jul 18, 2024
Copy link

github-actions bot commented Jul 18, 2024

Visit the preview URL for this PR (updated for commit 2403aaa):

https://koobiq-next--prs-150-uxq25aak.web.app

(expires Wed, 24 Jul 2024 08:54:48 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c

@artembelik
Copy link
Contributor

теперь код невозможно скрыть :)

image

@rmnturov
Copy link
Contributor

@NikGurev порядок вкладок неправильный. Исправь, плиз. Нужно HTML, CSS, TS

изображение изображение изображение

@NikGurev
Copy link
Contributor Author

@rmnturov сейчас в некоторых файлах вкладка с CSS файлом будет отображаться с текстом /** No CSS for this example */, вот так:
image

Суть в том, что это по сути не пустой файл. Удалим такие файлы позже, при переводе примеров в другой формат

@NikGurev NikGurev requested a review from artembelik July 19, 2024 09:00
@NikGurev NikGurev merged commit ab70e78 into main Jul 19, 2024
3 checks passed
@NikGurev NikGurev deleted the feat/DS-2602 branch July 19, 2024 10:16
sk8knut pushed a commit that referenced this pull request Jul 22, 2024
* 'main' of github.com:koobiq/angular-components:
  fix(docs): examples, api sections selection and scroll after link opened (#DS-2478) (#148)
  fix(datepicker, timepicker): lost focus after backspace/delete (#DS-2492) (#145)
  fix(modal): text in modal title is not cut off (#DS-2430) (#149)
  feat(docs): updated example code block show (#DS-2602) (#150)
  feat: added prettier support for json, js, ts files (#DS-2569) (#136)
  feat(timepicker): placeholder and view value localization (#DS-2059) (#144)
sk8knut pushed a commit that referenced this pull request Jul 22, 2024
* main:
  fix(docs): update tokens for disabled radio (#DS-2635)  (#146)
  feat: added prettier support for html, xml files (#DS-2653) (#152)
  fix(docs): examples, api sections selection and scroll after link opened (#DS-2478) (#148)
  fix(datepicker, timepicker): lost focus after backspace/delete (#DS-2492) (#145)
  fix(modal): text in modal title is not cut off (#DS-2430) (#149)
  feat(docs): updated example code block show (#DS-2602) (#150)
  feat: added prettier support for json, js, ts files (#DS-2569) (#136)
  feat(timepicker): placeholder and view value localization (#DS-2059) (#144)
  fix(docs): example start command change (#DS-2529) (#142)
  chore: bump version to 17.0.0-rc.10 w/ changelog
  fix(docs): highlight selected item (#DS-2597) (#137)
  feat(empty-state): added empty-state (#DS-2572) (#129)
  fix(docs,toast): single stack of toasts (#DS-2541) (#140)
  fix(select): "show more" text calculations (#DS-2649) (#135)
  fix(button): background for filled-contrast-fade-[off/on]-states-disabled-background
  fix(badge): outline badges borders color (#DS-3640)  (#139)
  fix(docs): fixed Algolia crawler
  feat: added prettier support for markdown and yaml (#DS-2650) (#133)
  feat: added prettier support for stylelint (#DS-2568) (#130)
  feat(docs): theming article rewrite (#DS-2544) (#114)

# Conflicts:
#	packages/components-dev/navbar/template.html
#	packages/docs-examples/components/navbar/navbar-overview/navbar-overview-example.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants