-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(radio): radio icon top positions fixed (#DS-2691) #162
Conversation
* 'main' of github.com:koobiq/angular-components: fix(docs): examples, api sections selection and scroll after link opened (#DS-2478) (#148) fix(datepicker, timepicker): lost focus after backspace/delete (#DS-2492) (#145) fix(modal): text in modal title is not cut off (#DS-2430) (#149) feat(docs): updated example code block show (#DS-2602) (#150) feat: added prettier support for json, js, ts files (#DS-2569) (#136) feat(timepicker): placeholder and view value localization (#DS-2059) (#144)
* 'main' of github.com:koobiq/angular-components: fix(list): replaced all size/padding tokens with css variables and fi… (#132)
* 'main' of github.com:koobiq/angular-components: fix(tree-select): localization for hiddenItemsText (#DS-2680) (#157)
Visit the preview URL for this PR (updated for commit 78ac1d7): https://koobiq-next--prs-162-8lf0li5f.web.app (expires Sun, 28 Jul 2024 14:35:22 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c9e37e518febda70d0317d07e8ceb35ac43c534c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
значения верные
хотелось бы видеть в формате токенов, раз уж они тут используются
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
для текущих размеров всё совпадает
* 'main' of github.com:koobiq/angular-components: fix(docs): default font (#DS-2648) (#151) chore: bump version to 17.0.0-rc.11 w/ changelog fix(link): alignment of the icon relative to the text (#DS-2690) (#163) feat(docs): welcome page - new images for empty state (#DS-2668) (#156) task(welcome): generic images on welcome page if not image for item (#DS-2669) (#159) fix(dropdown): focused keyboard dropdown items fix (#DS-2665) (#158) fix(radio): radio icon top positions fixed (#DS-2691) (#162)
* main: (39 commits) feat: migrated from jasmine/karma to jest (#DS-2192) (#154) feat(docs): added icon-items (#DS-2636) (#155) fix(typography): font-style italic fix (#DS-2671) (#153) chore: fixed version fix(docs): default font (#DS-2648) (#151) chore: bump version to 17.0.0-rc.11 w/ changelog fix(link): alignment of the icon relative to the text (#DS-2690) (#163) feat(docs): welcome page - new images for empty state (#DS-2668) (#156) task(welcome): generic images on welcome page if not image for item (#DS-2669) (#159) fix(dropdown): focused keyboard dropdown items fix (#DS-2665) (#158) fix(radio): radio icon top positions fixed (#DS-2691) (#162) fix(tree-select): localization for hiddenItemsText (#DS-2680) (#157) fix(list): replaced all size/padding tokens with css variables and fi… (#132) fix(sidepanel): fixed sidepanel max width (#DS-2314) (#141) fix(radio): fixed disabled radio styles (#DS-2666) (#143) fix(navbar): fixed navbar dropdown (#DS-2558) (#131) fix(docs): update tokens for disabled radio (#DS-2635) (#146) feat: added prettier support for html, xml files (#DS-2653) (#152) fix(docs): examples, api sections selection and scroll after link opened (#DS-2478) (#148) fix(datepicker, timepicker): lost focus after backspace/delete (#DS-2492) (#145) ... # Conflicts: # packages/docs-examples/components/alert/alert-close/alert-close-example.html # packages/docs-examples/components/alert/alert-content/alert-content-example.html # packages/docs-examples/components/alert/alert-size/alert-size-example.html # packages/docs-examples/components/alert/alert-status/alert-status-example.ts # packages/docs-examples/components/alert/alert-variants/alert-variants-example.html # packages/docs-examples/components/alert/alert-variants/alert-variants-example.ts
*with tokens