--namespace behaves as expected, applying to Kubecost request instead of Kubernetes request #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking API change. The previous behavior of --namespace/-n was to behave in the same way that it does in kubectl, where it scopes the Kubernetes API request. We want it to scope the Kubecost API request (when appropriate) instead. The old behavior of --namespace/-n is now in --kubecost-namespace/-N
dwbrown2
reviewed
Mar 10, 2021
michaelmdresser
added a commit
that referenced
this pull request
Mar 15, 2021
Caused by #33 This logic is now handled by --kubecost-namespace. Tested to verify no regression by using the -N and -n flags on a GKE cluster with two kubecost deployments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking API change. The previous behavior of
--namespace/-nwas to behave in the same way that it does inkubectl, where it scopes the Kubernetes API request. We want it to scope the Kubecost API request (when appropriate) instead.The old behavior of
--namespace/-nis now in--kubecost-namespace/-NVerified by using the new flag behavior (using the examples in the README, including against a staging installation using
-N) against a GKE cluster.