Remove unnecessary logic after --namespace change #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caused by #33 This logic is now handled by --kubecost-namespace. Tested to verify no regression by using the -N and -n flags on a GKE cluster with two kubecost deployments.
michaelmdresser
added a commit
that referenced
this pull request
Mar 31, 2021
#41 introduced an error with the TUI because the TUI was not providing the standard set of options and was instead relying on this old logic to set a namespace. The TUI now has the correct flags and defaults for the KubeOptions, mitigating the issue. Tested locally against a cluster running the nightly deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by #33
This logic is now handled by --kubecost-namespace.
Tested to verify no regression by using the -N and -n flags
on a GKE cluster with two kubecost deployments.