Skip to content

Commit

Permalink
Merge pull request #2164 from adleong/alex/suite-dreams
Browse files Browse the repository at this point in the history
Only require a GatewayClass if the gateway suite is being run
  • Loading branch information
k8s-ci-robot authored Jul 17, 2023
2 parents b1f461c + e990374 commit 3a5f760
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions conformance/utils/suite/suite.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,14 +142,15 @@ func New(s Options) *ConformanceTestSuite {
// Setup ensures the base resources required for conformance tests are installed
// in the cluster. It also ensures that all relevant resources are ready.
func (suite *ConformanceTestSuite) Setup(t *testing.T) {
t.Logf("Test Setup: Ensuring GatewayClass has been accepted")
suite.ControllerName = kubernetes.GWCMustHaveAcceptedConditionTrue(t, suite.Client, suite.TimeoutConfig, suite.GatewayClassName)

suite.Applier.GatewayClass = suite.GatewayClassName
suite.Applier.ControllerName = suite.ControllerName
suite.Applier.FS = suite.FS

if suite.SupportedFeatures.Has(SupportGateway) {
t.Logf("Test Setup: Ensuring GatewayClass has been accepted")
suite.ControllerName = kubernetes.GWCMustHaveAcceptedConditionTrue(t, suite.Client, suite.TimeoutConfig, suite.GatewayClassName)

suite.Applier.GatewayClass = suite.GatewayClassName
suite.Applier.ControllerName = suite.ControllerName

t.Logf("Test Setup: Applying base manifests")
suite.Applier.MustApplyWithCleanup(t, suite.Client, suite.TimeoutConfig, suite.BaseManifests, suite.Cleanup)

Expand Down

0 comments on commit 3a5f760

Please sign in to comment.