Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only require a GatewayClass if the gateway suite is being run #2164

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

adleong
Copy link
Contributor

@adleong adleong commented Jul 3, 2023

/kind test
/area conformance

What this PR does / why we need it:

When the conformance tests run, they require that a GatewayClass exists and that it has been accepted. However, this is not appropriate when testing mesh only conformance because mesh implementations do not necessarily have a GatewayClass. This change moves the GatewayClass requirement into the Gateway suite so that this is only checked when the Gateway feature is enabled.

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Alex Leong <alex@buoyant.io>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/test labels Jul 3, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 3, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jul 3, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @adleong!

It looks like this is your first PR to kubernetes-sigs/gateway-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 3, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @adleong. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 3, 2023
Copy link
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks !

@robscott
Copy link
Member

robscott commented Jul 5, 2023

Thanks @adleong!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adleong, arkodg, robscott

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023
@robscott
Copy link
Member

robscott commented Jul 5, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 5, 2023
@robscott
Copy link
Member

@adleong It looks like golangci-lint is failing:

conformance/utils/suite/suite.go:153: File is not `gofumpt`-ed (gofumpt)
		
�[0;31mTest FAILED: hack/../hack/verify-golint.sh 

Whenever you get time to fix that we should be good to merge this.

@robscott
Copy link
Member

@adleong Do you have time to take a look at the linting issue here? Would love to get this one in before v0.8.0 if you've got time for it.

@adleong
Copy link
Contributor Author

adleong commented Jul 17, 2023

Yes, sorry for the delay. I'll try to get this fixed up today.

Signed-off-by: Alex Leong <alex@buoyant.io>
@robscott
Copy link
Member

Thanks @adleong!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3a5f760 into kubernetes-sigs:main Jul 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants