Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove revision and heritage labels from helm charts #226

Closed
3 tasks
aramase opened this issue Jun 5, 2020 · 5 comments · Fixed by #240
Closed
3 tasks

Remove revision and heritage labels from helm charts #226

aramase opened this issue Jun 5, 2020 · 5 comments · Fixed by #240
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Milestone

Comments

@aramase
Copy link
Member

aramase commented Jun 5, 2020

{{- define "sscd.labels" -}}
labels:
heritage: "{{ .Release.Service }}"
release: "{{ .Release.Name }}"
revision: "{{ .Release.Revision }}"
chart: "{{ .Chart.Name }}"
chartVersion: "{{ .Chart.Version }}"
app: {{ template "sscd.name" . }}

@aramase
Copy link
Member Author

aramase commented Jun 5, 2020

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 5, 2020
@aramase
Copy link
Member Author

aramase commented Jun 5, 2020

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@aramase:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 5, 2020
@snooyen
Copy link
Contributor

snooyen commented Jun 30, 2020

I'd like to take this issue

@aramase
Copy link
Member Author

aramase commented Jun 30, 2020

Awesome! I'll assign this issue to you. If you have any questions, please feel free to post them here or ping us on #csi-secrets-store slack channel

/assign @snooyen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
3 participants