helm chart best practices

[aramase]

Co-authored-by: Sean Nguyen sean.nguyen@rackspace.com

What this PR does / why we need it:
This PR is #240 with just the label changes. The crds are still kept in templates dir to support helm2 and helm3. In the future, we could move the crds to crds dir for helm3 and add templates/crds.yaml with

{{- range $path, $bytes := .Files.Glob "crds/*.yaml" }}
  {{ $.Files.Get $path }}
---
{{- end }}

This would then need to be wrapped in a installCRDs conditional check, that users can set to true if running using helm2.

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #226, Fixes Azure/secrets-store-csi-driver-provider-azure#121

Special notes for your reviewer:

• Tested upgrade
  • Installed charts using charts/secrets-store-csi-driver
  • Upgraded using manifest_staging/charts/secrets-store-csi-driver

Thank you @snooyen for the changes in PR #240 🎉

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aramase

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aramase]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aramase]

/retest

[aramase]

Closing this in favor of #240

/close

[k8s-ci-robot]

@aramase: Closed this PR.

In response to this:

Closing this in favor of #240

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.