fix kicbase dockerfile to allow ppc64le and armv7 archs #13124

Hi @sharifelgamal, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

sharifelgamal · 2021-12-14T17:34:28Z

/ok-to-test

minikube-pr-bot · 2021-12-14T18:25:36Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13124) |
+----------------+----------+---------------------+
| minikube start | 45.5s    | 44.9s               |
| enable ingress | 29.6s    | 30.0s               |
+----------------+----------+---------------------+

Times for minikube (PR 13124) ingress: 30.1s 29.6s 29.1s 30.1s 31.1s
Times for minikube ingress: 29.1s 29.1s 29.6s 29.7s 30.6s

Times for minikube start: 46.5s 45.2s 46.2s 44.0s 45.8s
Times for minikube (PR 13124) start: 45.8s 43.9s 45.0s 44.6s 45.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13124) |
+----------------+----------+---------------------+
| minikube start | 26.7s    | 32.7s               |
| enable ingress | 22.1s    | 22.4s               |
+----------------+----------+---------------------+

Times for minikube (PR 13124) start: 57.4s 26.2s 26.3s 27.4s 25.9s
Times for minikube start: 27.3s 26.5s 26.7s 26.6s 26.4s

Times for minikube ingress: 23.9s 20.9s 21.9s 22.0s 21.9s
Times for minikube (PR 13124) ingress: 22.4s 22.4s 21.4s 22.9s 22.9s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13124) |
+----------------+----------+---------------------+
| minikube start | 42.1s    | 43.0s               |
| enable ingress | 30.4s    | 31.7s               |
+----------------+----------+---------------------+

Times for minikube start: 34.1s 45.6s 44.7s 45.0s 41.3s
Times for minikube (PR 13124) start: 40.9s 41.5s 45.0s 42.2s 45.5s

Times for minikube (PR 13124) ingress: 32.9s 33.4s 29.9s 32.9s 29.4s
Times for minikube ingress: 29.9s 29.0s 29.9s 29.9s 33.4s

minikube-pr-bot · 2021-12-14T19:52:54Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestNetworkPlugins/group/auto/DNS (gopogh)	0.85 (chart)
Hyperkit_macOS	TestNetworkPlugins/group/kindnet/Start (gopogh)	4.26 (chart)
Docker_Linux	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	4.48 (chart)
KVM_Linux_containerd	TestAddons/Setup (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/CertSync (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/CpCmd (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/FileSync (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/ImageCommands/ImageBuild (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/ImageCommands/ImageList (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/ImageCommands/ImageLoadDaemon (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/ImageCommands/ImageReloadDaemon (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/ImageCommands/ImageSaveToFile (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/ImageCommands/ImageTagAndLoadDaemon (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/MountCmd/any-port (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/MountCmd/specific-port (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/MySQL (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/NodeLabels (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/NonActiveRuntimeDisabled (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/ServiceCmd (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/SSHCmd (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/StatusCmd (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/UpdateContextCmd/no_changes (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/UpdateContextCmd/no_clusters (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/UpdateContextCmd/no_minikube_cluster (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/parallel/Version/components (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/serial/AuditLog (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/serial/CacheCmd/cache/cache_reload (gopogh)	5.74 (chart)
KVM_Linux_containerd	TestFunctional/serial/CacheCmd/cache/verify_cache_inside_node (gopogh)	5.74 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

deploy/kicbase/Dockerfile

cmd/minikube/cmd/start.go

… kicbase-arch

sharifelgamal · 2021-12-14T20:43:34Z

ok-to-build-image

minikube-pr-bot · 2021-12-14T21:40:50Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13124) |
+----------------+----------+---------------------+
| minikube start | 52.0s    | 49.3s               |
| enable ingress | 32.6s    | 32.3s               |
+----------------+----------+---------------------+

Times for minikube (PR 13124) start: 51.5s 49.4s 48.4s 48.6s 48.5s
Times for minikube start: 65.3s 48.1s 49.0s 48.2s 49.4s

Times for minikube ingress: 32.3s 32.3s 32.9s 32.4s 32.9s
Times for minikube (PR 13124) ingress: 31.8s 33.3s 32.0s 31.9s 32.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13124) |
+----------------+----------+---------------------+
| minikube start | 28.0s    | 29.3s               |
| enable ingress | 27.5s    | 28.1s               |
+----------------+----------+---------------------+

Times for minikube start: 42.4s 24.5s 24.4s 24.8s 24.1s
Times for minikube (PR 13124) start: 50.4s 24.8s 23.8s 23.9s 23.7s

Times for minikube ingress: 23.0s 28.0s 27.0s 35.0s 24.5s
Times for minikube (PR 13124) ingress: 23.0s 34.5s 28.0s 27.5s 27.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13124) |
+----------------+----------+---------------------+
| minikube start | 43.7s    | 43.6s               |
| enable ingress | 30.9s    | 24.1s               |
+----------------+----------+---------------------+

Times for minikube start: 46.8s 43.2s 42.6s 42.9s 42.8s
Times for minikube (PR 13124) start: 42.8s 44.2s 43.7s 43.2s 44.3s

Times for minikube ingress: 29.0s 32.0s 29.5s 32.0s 32.0s
Times for minikube (PR 13124) ingress: 18.5s 33.5s 28.0s 18.0s 22.5s

minikube-bot · 2021-12-14T21:54:39Z

Hi @sharifelgamal, we have updated your PR with the reference to newly built kicbase image. Pull the changes locally if you want to test with them or update your PR further.

minikube-pr-bot · 2021-12-14T23:34:44Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13124) |
+----------------+----------+---------------------+
| minikube start | 47.5s    | 46.7s               |
| enable ingress | 31.2s    | 31.1s               |
+----------------+----------+---------------------+

Times for minikube start: 49.1s 47.6s 46.9s 47.1s 46.9s
Times for minikube (PR 13124) start: 46.9s 46.8s 46.8s 46.5s 46.6s

Times for minikube ingress: 29.8s 30.8s 31.8s 32.3s 31.3s
Times for minikube (PR 13124) ingress: 31.3s 32.3s 31.8s 30.3s 29.8s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13124) |
+----------------+----------+---------------------+
| minikube start | 23.3s    | 34.8s               |
| enable ingress | 29.0s    | 26.5s               |
+----------------+----------+---------------------+

Times for minikube (PR 13124) ingress: 26.4s 25.9s 26.9s 27.4s 25.9s
Times for minikube ingress: 31.0s 34.5s 26.9s 26.0s 26.5s

Times for minikube start: 23.4s 23.7s 22.7s 23.6s 23.0s
Times for minikube (PR 13124) start: 82.3s 22.6s 22.5s 22.3s 24.3s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 13124) |
+----------------+----------+---------------------+
| minikube start | 43.3s    | 42.9s               |
| enable ingress | 32.3s    | 22.4s               |
+----------------+----------+---------------------+

Times for minikube start: 46.3s 42.7s 42.4s 42.7s 42.5s
Times for minikube (PR 13124) start: 42.6s 42.9s 42.5s 43.2s 43.3s

Times for minikube ingress: 32.4s 32.5s 32.0s 32.4s 32.0s
Times for minikube (PR 13124) ingress: 28.5s 19.0s 18.5s 27.5s 18.5s

minikube-pr-bot · 2021-12-15T03:23:36Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Windows	TestForceSystemdEnv (gopogh)	2.27 (chart)
Docker_macOS	TestAddons/parallel/CSI (gopogh)	4.27 (chart)
Docker_macOS	TestAddons/serial/GCPAuth (gopogh)	4.27 (chart)
Docker_macOS	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	4.27 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/kindnet/DNS (gopogh)	5.21 (chart)
Docker_macOS	TestMultiNode/serial/StartAfterStop (gopogh)	5.98 (chart)
KVM_Linux	TestNetworkPlugins/group/kubenet/Start (gopogh)	6.48 (chart)
Docker_macOS	TestFunctional/parallel/ImageCommands/ImageBuild (gopogh)	6.84 (chart)
Docker_macOS	TestFunctional/parallel/MountCmd/any-port (gopogh)	6.84 (chart)
Docker_macOS	TestMultiNode/serial/AddNode (gopogh)	6.84 (chart)
Docker_Linux_containerd	TestFunctional/serial/LogsFileCmd (gopogh)	8.20 (chart)
Docker_Linux_containerd	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	10.66 (chart)
Docker_Linux_containerd	TestStoppedBinaryUpgrade/Upgrade (gopogh)	10.66 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/calico/Start (gopogh)	14.68 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/enable-default-cni/DNS (gopogh)	17.12 (chart)
Docker_Windows	TestStartStop/group/no-preload/serial/Pause (gopogh)	17.24 (chart)
Docker_Linux_containerd	TestNetworkPlugins/group/bridge/DNS (gopogh)	17.86 (chart)
Docker_Windows	TestNetworkPlugins/group/enable-default-cni/Start (gopogh)	20.45 (chart)
Docker_Windows	TestNoKubernetes/serial/Start (gopogh)	28.57 (chart)
Docker_Windows	TestNetworkPlugins/group/bridge/Start (gopogh)	35.23 (chart)
Docker_macOS	TestFunctional/serial/ComponentHealth (gopogh)	41.03 (chart)
Docker_macOS	TestFunctional/serial/ExtraConfig (gopogh)	41.03 (chart)
Docker_Windows	TestNetworkPlugins/group/kubenet/Start (gopogh)	45.45 (chart)
Docker_Windows	TestNetworkPlugins/group/kindnet/Start (gopogh)	47.73 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	59.26 (chart)
Docker_Windows	TestFunctional/parallel/DryRun (gopogh)	64.77 (chart)
Docker_Windows	TestFunctional/parallel/InternationalLanguage (gopogh)	64.77 (chart)
Docker_Windows	TestFunctional/parallel/ImageCommands/ImageLoadFromFile (gopogh)	68.18 (chart)
Docker_macOS	TestNetworkPlugins/group/bridge/DNS (gopogh)	78.33 (chart)
Docker_Windows	TestFunctional/parallel/TunnelCmd/serial/WaitService/IngressIP (gopogh)	98.86 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

minikube-pr-bot · 2021-12-15T06:21:24Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd	TestStartStop/group/default-k8s-different-port/serial/Pause (gopogh)	1.94 (chart)
Docker_Linux	TestStartStop/group/no-preload/serial/Pause (gopogh)	3.15 (chart)
Docker_Linux	TestStartStop/group/old-k8s-version/serial/Pause (gopogh)	9.45 (chart)
KVM_Linux_containerd	TestPause/serial/SecondStartNoReconfiguration (gopogh)	11.48 (chart)
Hyper-V_Windows	TestNoKubernetes/serial/StartWithK8s (gopogh)	59.26 (chart)
Hyper-V_Windows	TestMultiNode/serial/PingHostFrom2Pods (gopogh)	100.00 (chart)
Hyper-V_Windows	TestMultiNode/serial/RestartKeepsNodes (gopogh)	100.00 (chart)

To see the flake rates of all tests by environment, click here.

cmd/minikube/cmd/start.go

k8s-ci-robot · 2021-12-15T22:03:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sharifelgamal, spowelljr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [sharifelgamal,spowelljr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fix kicbase dockerfile to allow ppc64le and armv7 archs

6b7168c

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2021

k8s-ci-robot requested review from medyagh and spowelljr December 8, 2021 00:08

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2021

return better error

b9e9df1

sharifelgamal changed the title ~~fix kicbase dockerfile to allow ppc64le and armv7 archs~~ WIP: fix kicbase dockerfile to allow ppc64le and armv7 archs Dec 8, 2021

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 8, 2021

format error message EVEN BETTER

da7020a

exclude crio for powerpc

6c7cf29

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 8, 2021

filter out podman for powerpc arch

a8ca32e

don't stop services that aren't installed

ba5e3d4

don't start podman socket when there is no podman

9700ca1

syntax

0e00ca4

don't add user to nonexistent group :)

72e654a

death by a thousand papercuts

3733f43

fix it actually

885ad28

Updating kicbase image to v0.0.28-1639444036-13124

efe0dd7

k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Dec 14, 2021

sharifelgamal changed the title ~~WIP: fix kicbase dockerfile to allow ppc64le and armv7 archs~~ fix kicbase dockerfile to allow ppc64le and armv7 archs Dec 14, 2021

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2021

spowelljr reviewed Dec 14, 2021

View reviewed changes

deploy/kicbase/Dockerfile Outdated Show resolved Hide resolved

medyagh requested changes Dec 14, 2021

View reviewed changes

cmd/minikube/cmd/start.go Outdated Show resolved Hide resolved

sharifelgamal added 4 commits December 14, 2021 12:36

address comments

c3688b6

Merge branch 'kicbase-arch' of github.com:sharifelgamal/minikube into…

cf64c36

… kicbase-arch

spacing

1c94864

remove unused error code

b70736a

Updating kicbase image to v0.0.28-1639515145-13124

a6ef730

spowelljr requested changes Dec 15, 2021

View reviewed changes

cmd/minikube/cmd/start.go Show resolved Hide resolved

spowelljr approved these changes Dec 15, 2021

View reviewed changes

sharifelgamal merged commit 5de7650 into kubernetes:master Dec 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix kicbase dockerfile to allow ppc64le and armv7 archs #13124

fix kicbase dockerfile to allow ppc64le and armv7 archs #13124

sharifelgamal commented Dec 8, 2021

sharifelgamal commented Dec 8, 2021

minikube-bot commented Dec 8, 2021

sharifelgamal commented Dec 8, 2021

minikube-bot commented Dec 8, 2021

sharifelgamal commented Dec 8, 2021

minikube-bot commented Dec 8, 2021

sharifelgamal commented Dec 8, 2021

minikube-bot commented Dec 8, 2021

sharifelgamal commented Dec 8, 2021

minikube-bot commented Dec 8, 2021

sharifelgamal commented Dec 8, 2021

minikube-bot commented Dec 8, 2021

sharifelgamal commented Dec 13, 2021

minikube-bot commented Dec 14, 2021

sharifelgamal commented Dec 14, 2021

minikube-bot commented Dec 14, 2021

sharifelgamal commented Dec 14, 2021

minikube-pr-bot commented Dec 14, 2021

minikube-pr-bot commented Dec 14, 2021

sharifelgamal commented Dec 14, 2021

minikube-pr-bot commented Dec 14, 2021

minikube-bot commented Dec 14, 2021

minikube-pr-bot commented Dec 14, 2021

minikube-pr-bot commented Dec 15, 2021

minikube-pr-bot commented Dec 15, 2021

k8s-ci-robot commented Dec 15, 2021

fix kicbase dockerfile to allow ppc64le and armv7 archs #13124

fix kicbase dockerfile to allow ppc64le and armv7 archs #13124

Conversation

sharifelgamal commented Dec 8, 2021

sharifelgamal commented Dec 8, 2021

minikube-bot commented Dec 8, 2021

sharifelgamal commented Dec 8, 2021

minikube-bot commented Dec 8, 2021

sharifelgamal commented Dec 8, 2021

minikube-bot commented Dec 8, 2021

sharifelgamal commented Dec 8, 2021

minikube-bot commented Dec 8, 2021

sharifelgamal commented Dec 8, 2021

minikube-bot commented Dec 8, 2021

sharifelgamal commented Dec 8, 2021

minikube-bot commented Dec 8, 2021

sharifelgamal commented Dec 13, 2021

minikube-bot commented Dec 14, 2021

sharifelgamal commented Dec 14, 2021

minikube-bot commented Dec 14, 2021

sharifelgamal commented Dec 14, 2021

minikube-pr-bot commented Dec 14, 2021

minikube-pr-bot commented Dec 14, 2021

sharifelgamal commented Dec 14, 2021

minikube-pr-bot commented Dec 14, 2021

minikube-bot commented Dec 14, 2021

minikube-pr-bot commented Dec 14, 2021

minikube-pr-bot commented Dec 15, 2021

minikube-pr-bot commented Dec 15, 2021

k8s-ci-robot commented Dec 15, 2021