Avoid instantiating separate pod store for every object managed by clusterloader attempt #3 #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
approved
wojtek-t
reviewed
Jul 14, 2022
clusterloader2/pkg/measurement/common/wait_for_controlled_pods.go
Outdated
Show resolved
Hide resolved
mborsz
force-pushed
the
pprof2
branch
3 times, most recently
from
2d65767
to
8e0bc3f
Compare
|
/hold cancel I updated the PR description with 5k node test results. |
k8s-ci-robot
removed
the
do-not-merge/hold
wojtek-t
reviewed
Jul 18, 2022
…usterloader Co-authored-by: Wojciech Tyczynski <wojtekt@google.com>
|
PTAL |
|
/lgtm /hold |
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mborsz, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel The test results in 5k are already in first comment. |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #2056 and #2016
Compared to #2056 it creates a single informer for all WaitForControlledPodsRunning instances (we have 4 such instances in load test) which cuts memory 4x, which makes memory consumption close to what we had before this PR (approx ~10% growth).
To improve cpu usage it performs indexing by ownerReference and uses it as a hint to find pods related to a given controller.
Comparison of resource consumption by pod running a 5k node test:
Cpu
With this PR:
Baseline:
Memory
So CPU usage is comparable to baseline and memory consumption grows from 10GiB to 12 GiB (16Gi is used as a limit for 5k tests).
/kind feature
/assign @wojtek-t