Fix WaitForControlledPodsRunning for deletion of deployments #2117
+296
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
TODOs:
|
Please fix |
mborsz
reviewed
Aug 11, 2022
tosi3k
force-pushed
the
fix-deployments
branch
2 times, most recently
from
72b51ea
to
227215f
Compare
mborsz
reviewed
Aug 11, 2022
clusterloader2/pkg/measurement/util/controlled_pods_indexer_test.go
Outdated
Show resolved
Hide resolved
tosi3k
force-pushed
the
fix-deployments
branch
4 times, most recently
from
60f51b6
to
0c9be6e
Compare
mborsz
reviewed
Aug 12, 2022
tosi3k
force-pushed
the
fix-deployments
branch
2 times, most recently
from
6254fbd
to
0959c3f
Compare
mborsz
reviewed
Aug 12, 2022
tosi3k
force-pushed
the
fix-deployments
branch
from
0959c3f
to
60da59e
Compare
|
/lgtm |
k8s-ci-robot
added
do-not-merge/hold
tosi3k
force-pushed
the
fix-deployments
branch
from
60da59e
to
639af9e
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mborsz, tosi3k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After submission of #2103 we handle "wait for deployment deletion" case incorrectly.
Once the ReplicaSet objects get deleted, we lose track of pods associated with the deployment so currently all pods are "deleted" when in fact that deployment's ReplicaSets are deleted, not the pods themselves.
/assign @mborsz