-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix WaitForControlledPodsRunning for deletion of deployments #2117
Conversation
TODOs:
|
Please fix |
72b51ea
to
227215f
Compare
clusterloader2/pkg/measurement/util/controlled_pods_indexer_test.go
Outdated
Show resolved
Hide resolved
60f51b6
to
0c9be6e
Compare
6254fbd
to
0959c3f
Compare
0959c3f
to
60da59e
Compare
/lgtm |
60da59e
to
639af9e
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mborsz, tosi3k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After submission of #2103 we handle "wait for deployment deletion" case incorrectly.
Once the ReplicaSet objects get deleted, we lose track of pods associated with the deployment so currently all pods are "deleted" when in fact that deployment's ReplicaSets are deleted, not the pods themselves.
/assign @mborsz