Translate Standardized Glossary page into Bahasa #24180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
Deploy preview for kubernetes-io-master-staging ready! Built with commit 7aeaa6e https://deploy-preview-24180--kubernetes-io-master-staging.netlify.app |
ariscahyadi
reviewed
Sep 29, 2020
There was a problem hiding this comment.
Thanks @habibrosyad for your contribution!
For me, it seems OK, just some nits to address.
Let's wait @girikuncoro or @irvifa to approve!
/lgtm
i18n/id.toml
Outdated
| [main_page_history] | ||
| other ="Riwayat halaman" | ||
| other ="Riwayat Halaman" |
There was a problem hiding this comment.
nit!
Suggested change
| other ="Riwayat Halaman" | |
| other ="Riwayat laman" |
i18n/id.toml
Outdated
|
|
||
| [seealso_heading] | ||
| other = "Lihat Juga" |
There was a problem hiding this comment.
nit!
Suggested change
| other = "Lihat Juga" | |
| other = "Lihat juga" |
i18n/id.toml
Outdated
| other = "Sinopsis" | ||
|
|
||
| [thirdparty_message] | ||
| other = """Bagian ini tertaut ke proyek-proyek pihak ketiga yang menyediakan fungsionalitas yang dibutuhkan oleh Kubernetes. Pencipta proyek Kubernetes tidak bertanggung jawab atas proyek-proyek tersebut. Halaman ini mengikuti <a href="https://github.com/cncf/foundation/blob/master/website-guidelines.md" target="_blank">pedoman website CNCF</a> dengan membuat daftar proyek menurut abjad. Untuk menambakan proyek ke dalam daftar ini, bacalah <a href="/docs/contribute/style/content-guide/#third-party-content">panduan</a> sebelum mengirimkan perubahan.""" |
There was a problem hiding this comment.
nit!
Suggested change
| other = """Bagian ini tertaut ke proyek-proyek pihak ketiga yang menyediakan fungsionalitas yang dibutuhkan oleh Kubernetes. Pencipta proyek Kubernetes tidak bertanggung jawab atas proyek-proyek tersebut. Halaman ini mengikuti <a href="https://github.com/cncf/foundation/blob/master/website-guidelines.md" target="_blank">pedoman website CNCF</a> dengan membuat daftar proyek menurut abjad. Untuk menambakan proyek ke dalam daftar ini, bacalah <a href="/docs/contribute/style/content-guide/#third-party-content">panduan</a> sebelum mengirimkan perubahan.""" | |
| other = """Bagian ini tertaut ke proyek-proyek pihak ketiga yang menyediakan fungsionalitas yang dibutuhkan oleh Kubernetes. Pencipta proyek Kubernetes tidak bertanggung jawab atas proyek-proyek tersebut. Laman ini mengikuti <a href="https://github.com/cncf/foundation/blob/master/website-guidelines.md" target="_blank">pedoman website CNCF</a> dengan membuat daftar proyek menurut abjad. Untuk menambahkan proyek ke dalam daftar ini, bacalah <a href="/docs/contribute/style/content-guide/#third-party-content">panduan</a> sebelum mengirimkan perubahan.""" |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7da3329f551076c08879585987e7763a82f826ee
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: irvifa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
@ariscahyadi should we wait until the person fix this or should we merge it now? |
|
I'm going to push the update in a moment... 😄 |
habibrosyad
force-pushed
the
k/w-glo
branch
from
961c1d5
to
7aeaa6e
Compare
k8s-ci-robot
removed
the
lgtm
|
@ariscahyadi @irvifa updated... |
|
Let wait until the build is finished |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
I think it is ok! |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9ed0b47f1d50504e330a27bedd8a6a0c0a784df5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate https://k8s.io/docs/reference/glossary into Bahasa as well as updating i18n to the latest upstream English updates.
/cc @girikuncoro @ariscahyadi