feat: deploy and functest make tasks #196

nestoracunablanco · 2024-07-03T13:59:28Z

This tasks are helpful when working wieh an external Kubernetes cluster.

The 'deploy' task installs the bundels and their dependencies, whilw the 'functest' task runs the function tests against the cluster.

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
No issue writen

Special notes for your reviewer:
The file deploy-kubevirt-and-cdi is very similar to the one in the ssp-operator repository. The plan is to update it in the other repository if the one there gets merged.

Release note:

kubevirt-bot · 2024-07-03T13:59:37Z

Hi @nestoracunablanco. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

0xFelix · 2024-07-08T08:16:52Z

scripts/deploy-kubevirt-and-cdi.sh

+kubectl patch -n ${KUBEVIRT_NAMESPACE} kubevirt kubevirt --type='json' -p '[{
+  "op": "add",
+  "path": "/spec/configuration/developerConfiguration/featureGates/-",
+  "value": "DataVolumes",
+},{
+  "op": "add",
+  "path": "/spec/configuration/developerConfiguration/featureGates/-",
+  "value": "CPUManager",
+},{
+  "op": "add",
+  "path": "/spec/configuration/developerConfiguration/featureGates/-",
+  "value": "KubevirtSeccompProfile",
+},{
+  "op": "add",
+  "path": "/spec/configuration/developerConfiguration/featureGates/-",
+  "value": "NUMA",
+},{
+  "op": "replace",
+  "path": "/spec/configuration/seccompConfiguration",
+  "value": {
+    "virtualMachineInstanceProfile": {
+      "customProfile": {
+        "localhostProfile": "kubevirt/kubevirt.json"
+      }
+    }
+  },
+}]'


None of them should be needed anymore.

To ensure that the function tests run successfully, both NUMA and GPU are required. However, I have removed the others.

0xFelix · 2024-07-08T08:18:14Z

scripts/deploy-kubevirt-and-cdi.sh

+#!/bin/bash
+set -e
+
+KUBEVIRT_NIGHTLY=$(curl -L https://storage.googleapis.com/kubevirt-prow/devel/nightly/release/kubevirt/kubevirt/latest)


Can you change it to KUBEVIRT_VERSION and make it use the latest stable version by default? This will help pinning KUBEVIRT_VERSION to a specific value in release branches.

0xFelix · 2024-07-08T08:18:30Z

scripts/deploy-kubevirt-and-cdi.sh

+KUBEVIRT_NAMESPACE=${1:-kubevirt}
+
+kubectl apply -f - <<EOF
+apiVersion: v1
+kind: Namespace
+metadata:
+  name: ${KUBEVIRT_NAMESPACE}
+EOF


Not sure this is needed.

0xFelix · 2024-07-08T08:19:18Z

scripts/deploy-kubevirt-and-cdi.sh

+kubectl apply -f - <<EOF
+apiVersion: v1
+kind: Namespace
+metadata:
+  name: ${CDI_NAMESPACE}
+EOF


Same, I don't think this is needed.

lyarwood · 2024-07-10T13:14:38Z

/ok-to-test

0xFelix · 2024-07-10T13:16:45Z

Makefile

+
+.PHONY: functest
+functest:
+	cd tests && kubectl config view --flatten > /tmp/kubeconfig && KUBECONFIG=/tmp/kubeconfig go test -v -timeout 0 ./functests/... -ginkgo.v -ginkgo.randomize-all $(FUNCTEST_EXTRA_ARGS)


What does writing to /tmp/kubeconfig first help with?

Hi @0xFelix, thank you for your comment.
If I understood the code correctly, in order for the function tests to work effectively, the variable KUBECONFIG must point to a kubectl config file. Given this information, I have thought of a solution: dumping the config to a temporary file and then loading it as an environment variable for the tests.
I am open to any ideas, comments, suggestions, etc. How would you approach solving this?

If you don't specify KUBECONFIG it should pick up the default ~/.kube/config that in this case is also used by kubectl. Did it not work without KUBECONFIG?

For example, in my case, when using minikube, it does not write the configuration to ~/.kube/config. Therefore, I came up with the idea of dumping the config to an extra file and changing KUBECONFIG only within the context of the function tests.

Where is kubectl config view --flatten looking at in this case? IIUC without KUBECONFIG it will look at ~/.kube/config?

Solved in a more elegant way. @0xFelix you can take a look.

lyarwood · 2024-07-10T13:22:32Z

scripts/deploy-kubevirt-and-cdi.sh

+
+
+# Deploying kubevirt
+KUBEVIRT_VERSION=$(latest_version "kubevirt")


Can you just use https://storage.googleapis.com/kubevirt-prow/devel/release/kubevirt/kubevirt/stable.txt as we do elsewhere?

common-instancetypes/scripts/kubevirtci.sh

Line 53 in d994341

KUBEVIRT_VERSION=$(curl -L https://storage.googleapis.com/kubevirt-prow/devel/release/kubevirt/kubevirt/stable.txt)

lyarwood · 2024-07-10T13:24:28Z

scripts/deploy-kubevirt-and-cdi.sh

+
+
+# Deploying CDI
+CDI_VERSION=$(latest_version "containerized-data-importer")


I don't think we have a version of stable.txt available for CDI so this is fine.

0xFelix

Looks good to me, thanks!

/lgtm

nestoracunablanco · 2024-07-15T09:57:14Z

Hey @0xFelix, I've made some updates to the code as the tests were failing. Could you please take another look?

0xFelix · 2024-07-15T10:06:32Z

Makefile

@@ -41,6 +44,14 @@ lint: generate
 generate: kustomize yq
 	scripts/generate.sh

+.PHONY: deploy
+deploy: generate lint


nit: generate is a dependency of lint, so it's redundant.

This tasks are helpful when working wieh an external Kubernetes cluster. The 'deploy' task installs the bundles and their dependencies, while the 'functest' task runs the function tests against the cluster. Signed-off-by: Nestor Acuna-Blanco <nestor.acuna@ibm.com>

nestoracunablanco · 2024-07-15T15:38:24Z

/retest

kubevirt-bot · 2024-07-15T15:38:40Z

@nestoracunablanco: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

0xFelix · 2024-07-16T08:24:01Z

/test all

0xFelix

Thanks!

/lgtm

@lyarwood Can you PTAL?

lyarwood · 2024-07-19T09:20:01Z

/approve

kubevirt-bot · 2024-07-19T09:20:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lyarwood

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [lyarwood]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kubevirt-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 3, 2024

kubevirt-bot requested review from 0xFelix and ksimon1 July 3, 2024 13:59

kubevirt-bot added the dco-signoff: no Indicates the PR's author has not DCO signed all their commits. label Jul 3, 2024

kubevirt-bot added the size/M label Jul 3, 2024

nestoracunablanco force-pushed the feat/deploy branch from b4aa937 to 2c87c07 Compare July 3, 2024 14:01

kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. and removed dco-signoff: no Indicates the PR's author has not DCO signed all their commits. labels Jul 3, 2024

0xFelix reviewed Jul 8, 2024

View reviewed changes

nestoracunablanco force-pushed the feat/deploy branch from 2c87c07 to 00cab67 Compare July 10, 2024 12:26

0xFelix reviewed Jul 10, 2024

View reviewed changes

lyarwood reviewed Jul 10, 2024

View reviewed changes

nestoracunablanco force-pushed the feat/deploy branch 2 times, most recently from ed4831b to 6634e73 Compare July 12, 2024 13:49

0xFelix approved these changes Jul 15, 2024

View reviewed changes

kubevirt-bot assigned 0xFelix Jul 15, 2024

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024

nestoracunablanco force-pushed the feat/deploy branch from 6634e73 to 55e5516 Compare July 15, 2024 09:54

kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 15, 2024

0xFelix reviewed Jul 15, 2024

View reviewed changes

nestoracunablanco force-pushed the feat/deploy branch from 55e5516 to 23b19c8 Compare July 15, 2024 11:21

0xFelix closed this Jul 16, 2024

0xFelix reopened this Jul 16, 2024

0xFelix mentioned this pull request Jul 16, 2024

fix: enable KUBECONFIG default for functest kubevirt/vm-console-proxy#156

Merged

0xFelix approved these changes Jul 19, 2024

View reviewed changes

kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2024

kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 19, 2024

kubevirt-bot merged commit 2bcf46f into kubevirt:main Jul 19, 2024
4 checks passed

nestoracunablanco deleted the feat/deploy branch July 19, 2024 09:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: deploy and functest make tasks #196

feat: deploy and functest make tasks #196

nestoracunablanco commented Jul 3, 2024

kubevirt-bot commented Jul 3, 2024

0xFelix Jul 8, 2024

nestoracunablanco Jul 10, 2024

0xFelix Jul 8, 2024

nestoracunablanco Jul 10, 2024

0xFelix Jul 8, 2024

nestoracunablanco Jul 10, 2024

0xFelix Jul 8, 2024

nestoracunablanco Jul 10, 2024

lyarwood commented Jul 10, 2024

0xFelix Jul 10, 2024

nestoracunablanco Jul 12, 2024

0xFelix Jul 12, 2024

nestoracunablanco Jul 12, 2024

0xFelix Jul 12, 2024

nestoracunablanco Jul 12, 2024

lyarwood Jul 10, 2024

nestoracunablanco Jul 12, 2024

lyarwood Jul 10, 2024

0xFelix left a comment

nestoracunablanco commented Jul 15, 2024

0xFelix Jul 15, 2024

nestoracunablanco Jul 15, 2024

nestoracunablanco commented Jul 15, 2024

kubevirt-bot commented Jul 15, 2024

0xFelix commented Jul 16, 2024

0xFelix left a comment

lyarwood commented Jul 19, 2024

kubevirt-bot commented Jul 19, 2024



		# Deploying kubevirt
		KUBEVIRT_VERSION=$(latest_version "kubevirt")



		# Deploying CDI
		CDI_VERSION=$(latest_version "containerized-data-importer")

feat: deploy and functest make tasks #196

feat: deploy and functest make tasks #196

Conversation

nestoracunablanco commented Jul 3, 2024

kubevirt-bot commented Jul 3, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lyarwood commented Jul 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xFelix left a comment

Choose a reason for hiding this comment

nestoracunablanco commented Jul 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nestoracunablanco commented Jul 15, 2024

kubevirt-bot commented Jul 15, 2024

0xFelix commented Jul 16, 2024

0xFelix left a comment

Choose a reason for hiding this comment

lyarwood commented Jul 19, 2024

kubevirt-bot commented Jul 19, 2024