Refactor test workflow #4457
Merged
Refactor test workflow #4457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will they still be run in parallel? |
|
@dev2049 yeah all envs run in parallel when using a matrix strategy |
hwchase17
reviewed
May 11, 2023
| run: | | ||
| make test | ||
| make tests | ||
| shell: bash |
There was a problem hiding this comment.
why is shell: bash needed?
There was a problem hiding this comment.
Rule of thumb is to always specify the shell in all workflows. The shell turns on strict mode which can make it much faster to debug.
dev2049
reviewed
May 11, 2023
| run: | | ||
| make test | ||
| make tests |
There was a problem hiding this comment.
why the rename, and why do we have both?
There was a problem hiding this comment.
as in why rename here, and why do we have both in makefile
There was a problem hiding this comment.
Oh rename is totally accidental, but it does the same thing. I'll follow up with a minor typo fix in a second after landing this.
jpzhangvincent
pushed a commit
to jpzhangvincent/langchain
that referenced
this pull request
May 12, 2023
# Refactor the test workflow This PR refactors the tests to run using a single test workflow. This makes it easier to relaunch failing tests and see in the UI which test failed since the jobs are grouped together. ## Before submitting ## Who can review?
EandrewJones
pushed a commit
to Oogway-Technologies/langchain
that referenced
this pull request
May 12, 2023
# Refactor the test workflow This PR refactors the tests to run using a single test workflow. This makes it easier to relaunch failing tests and see in the UI which test failed since the jobs are grouped together. ## Before submitting ## Who can review?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the test workflow
This PR refactors the tests to run using a single test workflow. This makes it easier to relaunch failing tests and see in the UI which test failed since the jobs are grouped together.
Before submitting
Who can review?