Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor test workflow #4457

Merged
merged 11 commits into from
May 11, 2023
Merged

Refactor test workflow #4457

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
d5a2c95
Update
eyurtsev May 10, 2023
961a6e0
Update
eyurtsev May 10, 2023
cd6f4d9
x
eyurtsev May 10, 2023
03be4bb
q
eyurtsev May 10, 2023
d735b7d
Simplify
eyurtsev May 10, 2023
4bdf24d
Update
eyurtsev May 10, 2023
1d1b831
uPdate
eyurtsev May 10, 2023
35245e6
Update
eyurtsev May 10, 2023
37717a2
Update
eyurtsev May 10, 2023
d214d86
Update
eyurtsev May 10, 2023
7d3f9d3
fix typo
eyurtsev May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix typo
  • Loading branch information
@eyurtsev
eyurtsev committed May 10, 2023
commit 7d3f9d389afdae9aacd7045a463bdc5e288dec08
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
echo "Running extended tests, installing dependencies with poetry..."
poetry install -E extended_testing
fi
- name: Run $${matrix.test_type}} tests
- name: Run $${{matrix.test_type}} tests
run: |
make tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the rename, and why do we have both?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as in why rename here, and why do we have both in makefile

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh rename is totally accidental, but it does the same thing. I'll follow up with a minor typo fix in a second after landing this.

shell: bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is shell: bash needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule of thumb is to always specify the shell in all workflows. The shell turns on strict mode which can make it much faster to debug.