chore: better support for event sender analytics paths #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusinto
requested review from
kinyoklion and
louis-launchdarkly
as code owners
kinyoklion
reviewed
Aug 28, 2023
| @@ -16,7 +17,12 @@ export class LDClient extends LDClientImpl { | |||
| constructor(clientSideID: string, platformInfo: Info, options: LDOptions) { | |||
| const em = new EventEmitter(); | |||
| const platform = new EdgePlatform(platformInfo); | |||
| super(clientSideID, platform, createOptions(options), createCallbacks(em)); | |||
| const internalOptions: internal.LDInternalOptions = { | |||
There was a problem hiding this comment.
Yeah, I like this much better.
kinyoklion
approved these changes
Aug 28, 2023
yusinto
commented
Aug 28, 2023
There was a problem hiding this comment.
Prettier auto fixes this
yusinto
commented
Aug 28, 2023
Comment on lines
+15
to
+27
| /** Valid paths are: | ||
| * /bulk | ||
| * /events/bulk/envId | ||
| * /mobile | ||
| */ | ||
| public readonly analyticsEventPath: string; | ||
|
|
||
| /** Valid paths are: | ||
| * /diagnostic | ||
| * /events/diagnostic/envId | ||
| * /mobile/events/diagnostic | ||
| */ | ||
| public readonly diagnosticEventPath: string; |
There was a problem hiding this comment.
We can be more pedantic and make these literal types instead of freeform strings. Any opinions?
yusinto
merged commit 1908227
into
yus/sc-214758/send-events-to-environment-endpoint-for-edge
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.