-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: better support for event sender analytics paths #259
Merged
yusinto
merged 4 commits into
yus/sc-214758/send-events-to-environment-endpoint-for-edge
from
yus/improve-event-sender-paths
Aug 28, 2023
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f95bdd6
chore: introduced LDInternalOptions to specify analytics and diagnost…
yusinto 7f647b5
chore: specify event sender paths for edge sdks
yusinto c5e78b4
chore: introduce includeAuthorizationHeader prop in ServiceEndpoints
yusinto 848aae0
fix: eslint error
yusinto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletions
5
packages/shared/common/src/internal/events/LDInternalOptions.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
export type LDInternalOptions = { | ||
analyticsEventPath?: string; | ||
diagnosticEventPath?: string; | ||
includeAuthorizationHeader?: boolean; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
import { EventEmitter } from 'node:events'; | ||
|
||
import { internal } from '@launchdarkly/js-sdk-common'; | ||
import { Info, LDClientImpl, LDOptions } from '@launchdarkly/js-server-sdk-common'; | ||
|
||
import EdgePlatform from '../platform'; | ||
|
@@ -16,7 +17,12 @@ export class LDClient extends LDClientImpl { | |
constructor(clientSideID: string, platformInfo: Info, options: LDOptions) { | ||
const em = new EventEmitter(); | ||
const platform = new EdgePlatform(platformInfo); | ||
super(clientSideID, platform, createOptions(options), createCallbacks(em)); | ||
const internalOptions: internal.LDInternalOptions = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I like this much better. |
||
analyticsEventPath: `/events/bulk/${clientSideID}`, | ||
diagnosticEventPath: `/events/diagnostic/${clientSideID}`, | ||
includeAuthorizationHeader: false, | ||
}; | ||
super(clientSideID, platform, createOptions(options), createCallbacks(em), internalOptions); | ||
this.emitter = em; | ||
} | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can be more pedantic and make these literal types instead of freeform strings. Any opinions?