Fix all flaky tests #2097
Closed
Fix all flaky tests #2097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
force-pushed
the
marco/flaky-tests
branch
2 times, most recently
from
87525e8
to
faf8ee1
Compare
MarcoPolo
changed the title
require.Eventually behavior to fix flaky tests in CI
|
Closing per discussion in triage: this branch was experimental and trying many things. Fixes have mostly gone in. Removing parallel dials from CI is being held off and is its own branch here: #2141 |
sukunrt
added a commit
to sukunrt/go-libp2p
that referenced
this pull request
Apr 3, 2023
originally created by @MarcoPolo here libp2p#2097
MarcoPolo
pushed a commit
that referenced
this pull request
May 8, 2023
originally created by @MarcoPolo here #2097
gts2030
pushed a commit
to superblock-dev/go-libp2p
that referenced
this pull request
May 23, 2024
originally created by @MarcoPolo here libp2p/go-libp2p#2097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the commit message at MarcoPolo/testify@a133586 for more details