Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add docs for debugging flaky tests #2216

Merged
merged 1 commit into from
May 8, 2023
Merged

tests: add docs for debugging flaky tests #2216

merged 1 commit into from
May 8, 2023

Conversation

sukunrt
Copy link
Member

@sukunrt sukunrt commented Mar 24, 2023

No description provided.

MarcoPolo
MarcoPolo approved these changes Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@MarcoPolo MarcoPolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this in :)

For historical context (hi future user!), I originally wrote this when debugging flaky tests.

Not only do we have noisy neighbors in CI, we also run package tests in parallel, which contributes to the contention.

@sukunrt
Copy link
Member Author

sukunrt commented Apr 3, 2023

fixed the commit message :)

@MarcoPolo MarcoPolo merged commit 948cab8 into libp2p:master May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoPolo MarcoPolo MarcoPolo approved these changes

@marten-seemann marten-seemann marten-seemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sukunrt @MarcoPolo @marten-seemann