Unify and enforce same MSRV across workspace #3787
Milestone
Comments
4 tasks
4 tasks
mergify bot
pushed a commit
that referenced
this issue
May 2, 2023
Previously, we would specify the version and path of our workspace dependencies in each of our crates. This is error prone as #3658 (comment) for example shows. Problems like these happened in the past too. There is no need for us to ever depend on a earlier version than the most current one in our crates. It thus makes sense that we manage this version in a single place. Cargo supports a feature called "workspace inheritance" which allows us to share a dependency declaration across a workspace and inherit it with `{ workspace = true }`. We do this for all our workspace dependencies and for the MSRV. Resolves #3787. Pull-Request: #3715.
umgefahren
pushed a commit
to umgefahren/rust-libp2p
that referenced
this issue
Mar 8, 2024
Previously, we would specify the version and path of our workspace dependencies in each of our crates. This is error prone as libp2p#3658 (comment) for example shows. Problems like these happened in the past too. There is no need for us to ever depend on a earlier version than the most current one in our crates. It thus makes sense that we manage this version in a single place. Cargo supports a feature called "workspace inheritance" which allows us to share a dependency declaration across a workspace and inherit it with `{ workspace = true }`. We do this for all our workspace dependencies and for the MSRV. Resolves libp2p#3787. Pull-Request: libp2p#3715.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Motivation
Smaller caches.
Less complexity in CI and overall.
Current Implementation
Are you planning to do it yourself in a pull request?
Yes.
The text was updated successfully, but these errors were encountered: