feat(swarm): rename NetworkBehaviourAction to ToSwarm
#3658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
approved these changes
Mar 23, 2023
mxinden
reviewed
Mar 30, 2023
| @@ -65,7 +65,7 @@ use libp2p_core::{Endpoint, Multiaddr}; | |||
| use libp2p_identity::PeerId; | |||
| use libp2p_swarm::{ | |||
| dummy, CloseConnection, ConnectionDenied, ConnectionId, FromSwarm, NetworkBehaviour, | |||
| NetworkBehaviourAction, PollParameters, THandler, THandlerInEvent, THandlerOutEvent, | |||
| PollParameters, THandler, THandlerInEvent, THandlerOutEvent, ToSwarm, | |||
There was a problem hiding this comment.
With this change libp2p-allow-block-list depends on libp2p-swarm >=0.42.1, but its Cargo.toml allows libp2p-swarm v0.42.0.
I don't think this is a pressing issue, thus not sure whether to release a patch release of libp2p-allow-block-list with the above restriction. What do you think @thomaseizinger?
The same applies to other crates below that we have released since.
There was a problem hiding this comment.
Right, it is an issue. We should have bumped the dependency version but not the version of each dependent crate.
I'll send a fix.
Can we mitigate this with an automated check somehow? Perhaps -Z minimal-versions helps?
There was a problem hiding this comment.
Done here: #3711.
There was a problem hiding this comment.
Can we mitigate this with an automated check somehow? Perhaps
-Z minimal-versionshelps?
I think I found a solution: #3715
This was referenced Mar 30, 2023
mergify bot
pushed a commit
that referenced
this pull request
Apr 5, 2023
With #3658, these crates depend on the `0.42.1` release to access the new `ToSwarm` type. With the currently specified version, a user could theoretically run into a compile error if they pin `libp2p-swarm` to `0.42.0` in their lockfile but update to the latest patch release of one of these crates. Pull-Request: #3711.
mergify bot
pushed a commit
that referenced
this pull request
May 2, 2023
Previously, we would specify the version and path of our workspace dependencies in each of our crates. This is error prone as #3658 (comment) for example shows. Problems like these happened in the past too. There is no need for us to ever depend on a earlier version than the most current one in our crates. It thus makes sense that we manage this version in a single place. Cargo supports a feature called "workspace inheritance" which allows us to share a dependency declaration across a workspace and inherit it with `{ workspace = true }`. We do this for all our workspace dependencies and for the MSRV. Resolves #3787. Pull-Request: #3715.
umgefahren
pushed a commit
to umgefahren/rust-libp2p
that referenced
this pull request
Mar 8, 2024
Resolves libp2p#3123. Pull-Request: libp2p#3658.
umgefahren
pushed a commit
to umgefahren/rust-libp2p
that referenced
this pull request
Mar 8, 2024
With libp2p#3658, these crates depend on the `0.42.1` release to access the new `ToSwarm` type. With the currently specified version, a user could theoretically run into a compile error if they pin `libp2p-swarm` to `0.42.0` in their lockfile but update to the latest patch release of one of these crates. Pull-Request: libp2p#3711.
umgefahren
pushed a commit
to umgefahren/rust-libp2p
that referenced
this pull request
Mar 8, 2024
Previously, we would specify the version and path of our workspace dependencies in each of our crates. This is error prone as libp2p#3658 (comment) for example shows. Problems like these happened in the past too. There is no need for us to ever depend on a earlier version than the most current one in our crates. It thus makes sense that we manage this version in a single place. Cargo supports a feature called "workspace inheritance" which allows us to share a dependency declaration across a workspace and inherit it with `{ workspace = true }`. We do this for all our workspace dependencies and for the MSRV. Resolves libp2p#3787. Pull-Request: libp2p#3715.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #3123.
Notes & open questions
Do we need to bump the versions of all dependents here? It is backwards-compatible, meaning we can patch-release
libp2p-swarmand all dependencies should still be working, even if the new version is pulled in.Change checklist