Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump multiaddr from 0.17.0 to 0.17.1 #3688

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 27, 2023

Bumps multiaddr from 0.17.0 to 0.17.1.

Release notes

Sourced from multiaddr's releases.

v0.17.1

See changelog for details.

Changelog

Sourced from multiaddr's changelog.

0.17.1

  • Rename string representation of WebRTC protocol from /webrtc to /webrt-direct. For backwards compatibility /webrtc will still be decoded to Protocol::WebRTC, but Protocol::WebRTC will from now on always be encoded as /webrtc-direct. See [multiformats/multiaddr discussion] and PR 84 for context.
    assert_eq!(
        Multiaddr::empty().with(Protocol::WebRTC),
        "/webrtc".parse().unwrap(),
    );
    assert_eq!(
        Multiaddr::empty().with(Protocol::WebRTC),
        "/webrtc-direct".parse().unwrap(),
    );
    assert_eq!(
        "/webrtc-direct",
        Multiaddr::empty().with(Protocol::WebRTC).to_string(),
    );
    assert_ne!(
        "/webrtc",
        Multiaddr::empty().with(Protocol::WebRTC).to_string(),
    );
Commits
  • 1b363b0 fix: Rename Protocol::WebRTC string rep /webrtc to /webrtc-direct (#84)
  • See full diff in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [multiaddr](https://github.com/multiformats/rust-multiaddr) from 0.17.0 to 0.17.1.
- [Release notes](https://github.com/multiformats/rust-multiaddr/releases)
- [Changelog](https://github.com/multiformats/rust-multiaddr/blob/master/CHANGELOG.md)
- [Commits](multiformats/rust-multiaddr@v0.17.0...v0.17.1)

---
updated-dependencies:
- dependency-name: multiaddr
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Mar 27, 2023
Copy link
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomaseizinger!

As far as I can tell, version bumps of libp2p-xxx crates are not required here.

@mxinden
Copy link
Member

mxinden commented Mar 30, 2023

rust-v0.50.0 x rust-libp2p-head (webrtc),failure

chromium-js-v0.41.0 x rust-libp2p-head (webrtc),failure

I am assuming that this is due to the older versions still using /webrtc. Let me ponder a bit how best to solve this.

mxinden added a commit to mxinden/test-plans that referenced this pull request Mar 30, 2023
This commit disables the WebRTC tests for rust-libp2p v0.50.0 and v0.51.0 and
chromium-js v0.41.0 and v0.42.0. Neither of these support the new
`/webrtc-direct` (see
multiformats/multiaddr#150 for
context on rename).

The missing support is blocking libp2p/rust-libp2p#3688
namely to upgrade to using `/webrtc-direct`. (Note that this is only blocking
CI. Users can already use `/webrtc-direct` with the latest released
rust-libp2p.)

We will backport `/webrtc-direct` support to the rust-libp2p `v0.51.0` interop
binary and then re-enable it here. I assume we can do the same for js-libp2p v0.42.0.

Instead of disabling the versions with missing support for `/webrtc-direct` we
could as well patch our interoperability test logic. For the sake of simplicity,
I am proposing simply disabling the versions for now.
@mxinden
Copy link
Member

mxinden commented Mar 30, 2023

Let's move the discussion to libp2p/test-plans#160.

mxinden added a commit to libp2p/test-plans that referenced this pull request Apr 4, 2023
This commit disables the WebRTC tests for rust-libp2p v0.50.0 and v0.51.0 and
chromium-js v0.41.0 and v0.42.0. Neither of these support the new
`/webrtc-direct` (see
multiformats/multiaddr#150 for
context on rename).

The missing support is blocking libp2p/rust-libp2p#3688
namely to upgrade to using `/webrtc-direct`. (Note that this is only blocking
CI. Users can already use `/webrtc-direct` with the latest released
rust-libp2p.)

We will backport `/webrtc-direct` support to the rust-libp2p `v0.51.0` interop
binary and then re-enable it here.

Instead of disabling the versions with missing support for `/webrtc-direct` we
could as well patch our interoperability test logic. For the sake of simplicity,
I am proposing simply disabling the versions for now.
@mxinden
Copy link
Member

mxinden commented Apr 4, 2023

Interop failure due to #3708 not yet merged.

@mergify mergify bot merged commit 95fa913 into master Apr 4, 2023
@mergify mergify bot deleted the dependabot/cargo/multiaddr-0.17.1 branch April 4, 2023 13:38
MarcoPolo pushed a commit to mxinden/test-plans that referenced this pull request Apr 13, 2023
This commit disables the WebRTC tests for rust-libp2p v0.50.0 and v0.51.0 and
chromium-js v0.41.0 and v0.42.0. Neither of these support the new
`/webrtc-direct` (see
multiformats/multiaddr#150 for
context on rename).

The missing support is blocking libp2p/rust-libp2p#3688
namely to upgrade to using `/webrtc-direct`. (Note that this is only blocking
CI. Users can already use `/webrtc-direct` with the latest released
rust-libp2p.)

We will backport `/webrtc-direct` support to the rust-libp2p `v0.51.0` interop
binary and then re-enable it here.

Instead of disabling the versions with missing support for `/webrtc-direct` we
could as well patch our interoperability test logic. For the sake of simplicity,
I am proposing simply disabling the versions for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file rust Pull requests that update Rust code send-it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants