Skip to content

Commit

Permalink
fix(versions): disable webrtc tests (libp2p#160)
Browse files Browse the repository at this point in the history
This commit disables the WebRTC tests for rust-libp2p v0.50.0 and v0.51.0 and
chromium-js v0.41.0 and v0.42.0. Neither of these support the new
`/webrtc-direct` (see
multiformats/multiaddr#150 for
context on rename).

The missing support is blocking libp2p/rust-libp2p#3688
namely to upgrade to using `/webrtc-direct`. (Note that this is only blocking
CI. Users can already use `/webrtc-direct` with the latest released
rust-libp2p.)

We will backport `/webrtc-direct` support to the rust-libp2p `v0.51.0` interop
binary and then re-enable it here.

Instead of disabling the versions with missing support for `/webrtc-direct` we
could as well patch our interoperability test logic. For the sake of simplicity,
I am proposing simply disabling the versions for now.
  • Loading branch information
mxinden authored and MarcoPolo committed Apr 13, 2023
1 parent e5d6b55 commit ab88ee6
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions multidim-interop/versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,14 @@ export const versions: Array<Version> = [
{
id: "rust-v0.50.0",
containerImageID: rustv050.imageID,
transports: ["ws", "tcp", "quic-v1", "webrtc"],
transports: ["ws", "tcp", "quic-v1"],
secureChannels: ["tls", "noise"],
muxers: ["mplex", "yamux"],
},
{
id: "rust-v0.51.0",
containerImageID: rustv051.imageID,
transports: ["ws", "tcp", "quic-v1", "webrtc"],
transports: ["ws", "tcp", "quic-v1"],
secureChannels: ["tls", "noise"],
muxers: ["mplex", "yamux"],
},
Expand All @@ -68,14 +68,14 @@ export const versions: Array<Version> = [
{
id: "chromium-js-v0.41.0",
containerImageID: chromiumJsV041.imageID,
transports: [{ name: "webtransport", onlyDial: true }, { name: "webrtc", onlyDial: true }],
transports: [{ name: "webtransport", onlyDial: true }],
secureChannels: [],
muxers: []
},
{
id: "chromium-js-v0.42.0",
containerImageID: chromiumJsV042.imageID,
transports: [{ name: "webtransport", onlyDial: true }, { name: "webrtc", onlyDial: true }, { name: "wss", onlyDial: true }],
transports: [{ name: "webtransport", onlyDial: true }, { name: "wss", onlyDial: true }],
secureChannels: ["noise"],
muxers: ["mplex", "yamux"]
},
Expand Down

0 comments on commit ab88ee6

Please sign in to comment.