feat(quic): allow disabling of path MTU discovery #4823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to simplify public API
mxinden
reviewed
Nov 10, 2023
This comment was marked as resolved.
This comment was marked as resolved.
nazar-pc
force-pushed
the
mtu-path-discovery-configuration
branch
from
a3b7c8d
to
5a50ef8
Compare
thomaseizinger
changed the title
nazar-pc
force-pushed
the
mtu-path-discovery-configuration
branch
from
f4b8218
to
12ec98b
Compare
|
Yep, apologies, this trivial PR will certainly need to be squashed |
nazar-pc
force-pushed
the
mtu-path-discovery-configuration
branch
from
12ec98b
to
43d6211
Compare
We always squash-merge! :) |
thomaseizinger
approved these changes
Nov 12, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Path MTU discovery seems to be broken in QUIC right now on Windows and we had to disable it in Subspace.
Related: autonomys/subspace#2195.
Attributions
Co-authored-by: Shamil Gadelshin shamilgadelshin@gmail.com
Notes & open questions
It is following default behavior of quinn and just adds an option to change that if necessary.
Change checklist