Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[query] Query handlers refactoring #2872

Merged
merged 24 commits into from
Nov 16, 2020
Merged

Commits on Nov 11, 2020

  1. Initial commit for proposed query handlers refactoring:

     * updated CustomHandler interface
     * unified how query routes are added. no need to pass router around and wrapping is done in one place.
     * routes are registered with names so they could be easily found later when custom handlers are registered.
    soundvibe committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    69e69d5 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into linasn/query-handlers-refactoring

    * master: (28 commits)
      [dbnode] Add claims for index segments volume index (#2846)
      [dbnode] Remove namespaces from example config and integration tests (#2866)
      [dbnode] Resurrect flaky test skip (#2868)
      [aggregator] Fix checkCampaignStateLoop (#2867)
      [dbnode] implement deletion method in namespace kvadmin service (#2861)
      Replace closer with resource package (#2864)
      Add coding style guide (#2831)
      Add GOVERNANCE.md to describe governance (#2830)
      Add COMPATIBILITY.md to describe version compatibility (#2829)
      Refactor etcd config as discovery section with convenience types (#2843)
      Refactor x/lockfile into dbnode/server (#2862)
      [lint] Disable nlreturn linter (#2865)
      [m3cluster] Expose placement algorithm in placement service (#2858)
      [etcd] Set reasonable cluster connection/sync settings by default (#2860)
      [dbnode] Use bits.LeadingZeros64 to improve encoder performance (#2857)
      Cleanup m3nsch leftovers (#2856)
      Update ci-scripts to correct coverage tracking (#2854)
      [aggregator] Process campaign state without waiting for first campaign check interval (#2855)
      Bump go to 1.14 (#2853)
      [query] Remove single series error from M3
      ...
    soundvibe committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    1fe3aa1 View commit details
    Browse the repository at this point in the history
  3. trying to make linter happy

    soundvibe committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    5ebcdeb View commit details
    Browse the repository at this point in the history
  4. linter fixes

    soundvibe committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    67814a7 View commit details
    Browse the repository at this point in the history
  5. revert old behaviour

    soundvibe committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    eaddb85 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3b04c30 View commit details
    Browse the repository at this point in the history
  7. fixed code formatting

    soundvibe committed Nov 11, 2020
    Configuration menu
    Copy the full SHA
    ea121f2 View commit details
    Browse the repository at this point in the history

Commits on Nov 12, 2020

  1. Configuration menu
    Copy the full SHA
    dd38ead View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a3bd18a View commit details
    Browse the repository at this point in the history
  3. [coordinator] Set default namespace tag to avoid colliding with commo…

    …nly used "namespace" label (#2878)
    
    * [coordinator] Set default namespace tag to avoid colliding with common "namespace" default value
    
    * Use defined constant
    
    * Add downsampler test case to demonstrate override namespace tag
    
    Co-authored-by: Wesley Kim <wesley@chronosphere.io>
    robskillington and wesleyk committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    3b5c0ff View commit details
    Browse the repository at this point in the history
  4. Improve some slow tests (#2881)

    * Improe some slow tests
    
    * lint
    
    * lint
    
    * goddamn imports
    vdarulis authored Nov 12, 2020
    Configuration menu
    Copy the full SHA
    96a5efb View commit details
    Browse the repository at this point in the history
  5. Changes after code review.

    soundvibe committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    9b9c6da View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    78db238 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9af0b72 View commit details
    Browse the repository at this point in the history
  8. linter fixes

    soundvibe committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    5814642 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a7d6696 View commit details
    Browse the repository at this point in the history
  10. Merge branch 'master' into linasn/query-handlers-refactoring

    * master:
      [query] Remove dead code in prom package (#2871)
      Improve some slow tests (#2881)
      [coordinator] Set default namespace tag to avoid colliding with commonly used "namespace" label (#2878)
      [dbnode] Introduce Aggregator type (#2840)
      [dbnode] Refactor wide query path (#2826)
      [dbnode] Add validation to ensure index claims is singleton (#2877)
      [dbnode] Default HostID and Discovery config for minimal config (#2876)
    soundvibe committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    03f5e35 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3a3a885 View commit details
    Browse the repository at this point in the history
  12. formatted code

    soundvibe committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    2d71d9a View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2020

  1. Configuration menu
    Copy the full SHA
    6b82ce4 View commit details
    Browse the repository at this point in the history
  2. Update src/query/api/v1/httpd/handler_test.go

    Co-authored-by: Vilius Pranckaitis <vpranckaitis@gmail.com>
    soundvibe and vpranckaitis authored Nov 16, 2020
    Configuration menu
    Copy the full SHA
    c46d9fd View commit details
    Browse the repository at this point in the history
  3. Update src/query/api/v1/httpd/handler_test.go

    Co-authored-by: Vilius Pranckaitis <vpranckaitis@gmail.com>
    soundvibe and vpranckaitis authored Nov 16, 2020
    Configuration menu
    Copy the full SHA
    ff3a894 View commit details
    Browse the repository at this point in the history
  4. More handler tests.

    soundvibe committed Nov 16, 2020
    Configuration menu
    Copy the full SHA
    3bc8e4c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b956426 View commit details
    Browse the repository at this point in the history