Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compliance for ECG and MEQP coding standards #779

Open
10 of 12 tasks
ebizmarts-keller opened this issue Aug 22, 2018 · 0 comments
Open
10 of 12 tasks

Compliance for ECG and MEQP coding standards #779

ebizmarts-keller opened this issue Aug 22, 2018 · 0 comments

Comments

@ebizmarts-keller
Copy link
Contributor

ebizmarts-keller commented Aug 22, 2018 •
edited by roberto-ebizmarts
Loading

Make the necessary modifications to adhere to the ecg_coding_standards from Magento

  • Lines exceeds 120 characters.
  • Usage of Date without magento's core class.
  • Nesting level more than 5.
  • Method complexity over 8.
  • Line exceeds 120 characters in Reg-Exp (emailcatcher.phtml).
  • Variable with no CamelCase in objects data and constants.
  • Unescaped output detected in HTML passed through variable (notifications.phtml).
  • MySQL4 obsolete classes.
  • Database access and queries not in model classes.
  • Usage of file and curl methods (mkdir, rmdir, curl_setopt, etc).
  • Usage of file and methods fopen, fclose.
  • Usage of deprecated md5 functions.
@ebizmarts-keller ebizmarts-keller changed the title Compliance for ecg_coding_standards Compliance for ECG and MEQP coding standards Aug 23, 2018
luciaebizmarts added a commit that referenced this issue Aug 24, 2018
@luciaebizmarts
cs #779 Ebizmarts_MailChimp_Model_Email_Template
7f15144
luciaebizmarts added a commit that referenced this issue Aug 24, 2018
@luciaebizmarts
cs #779 Ebizmarts_MailChimp_Model_Email_Queue
81021f6
luciaebizmarts added a commit that referenced this issue Aug 24, 2018
@luciaebizmarts
cs #779 Ebizmarts_MailChimp_Model_Api_PromoCodes
1ab733e
luciaebizmarts added a commit that referenced this issue Aug 24, 2018
@luciaebizmarts
cs #779 Ebizmarts_MailChimp_Model_Api_Stores
9fd4701
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
c0d25a6
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
6676479
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
900db10
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
74f5282
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
334b4f7
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
124b913
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
4c9f3c9
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
14c57fb
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
54269cb
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
8bf690e
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
f3a6319
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
88b04ad
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
9682874
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
608d627
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
dec1b3d
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
849d020
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
740cff6
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
f0ac02a
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
c0315f0
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
718798e
Juan-ebizmarts added a commit that referenced this issue Aug 24, 2018
@Juan-ebizmarts
code sniffer #779
053e025
luciaebizmarts added a commit that referenced this issue Aug 30, 2018
@luciaebizmarts
cs #779 Ebizmarts_MailChimp_Model_Api_Orders
6516c7d
luciaebizmarts added a commit that referenced this issue Aug 30, 2018
@luciaebizmarts
cs #779 Ebizmarts_MailChimp_Model_Email_Queue
06602f7
luciaebizmarts added a commit that referenced this issue Aug 30, 2018
@luciaebizmarts
cs #779 Ebizmarts_MailChimp_Model_Api_Stores
85ce9d0
luciaebizmarts added a commit that referenced this issue Aug 30, 2018
@luciaebizmarts
cs #779 Ebizmarts_MailChimp_Model_Api_PromoCodes
5f6a3d6
luciaebizmarts added a commit that referenced this issue Aug 30, 2018
@luciaebizmarts
cs #779 Ebizmarts_MailChimp_Model_Api_Customers
6a0ba59
luciaebizmarts added a commit that referenced this issue Aug 30, 2018
@luciaebizmarts
cs #779 Ebizmarts_MailChimp_Model_Api_Subscribers
bd91b4b
luciaebizmarts added a commit that referenced this issue Aug 30, 2018
@luciaebizmarts
cs #779 Ebizmarts_MailChimp_Model_Email_Template
e11ed84
luciaebizmarts added a commit that referenced this issue Aug 30, 2018
@luciaebizmarts
cs #779 Ebizmarts_MailChimp_Model_Api_StoresTest
19e80db
luciaebizmarts added a commit that referenced this issue Aug 30, 2018
@luciaebizmarts
cs #779 Ebizmarts_MailChimp_Helper_Data
e95740f
@giorello giorello self-assigned this Jun 24, 2019
@giorello giorello added this to the 1.1.17 milestone Jun 24, 2019
@Santiagoebizmarts Santiagoebizmarts removed this from the 1.1.17 milestone Jun 27, 2019
@giorello giorello mentioned this issue Jul 9, 2019
Merged
@giorello giorello removed their assignment Jul 23, 2019
This was referenced Sep 23, 2019
Closed
Closed
Merged
@giorello giorello mentioned this issue Sep 23, 2019
Merged
roberto-ebizmarts added a commit that referenced this issue Sep 24, 2019
@roberto-ebizmarts
Deleting some "Lines exceeds 120 characters." issue
887a12f 
ref. #779
@giorello giorello mentioned this issue Sep 26, 2019
Merged
@roberto-ebizmarts roberto-ebizmarts mentioned this issue Oct 7, 2019
Merged
roberto-ebizmarts added a commit that referenced this issue Oct 11, 2019
@roberto-ebizmarts
Fixing phpcs issue:
62ea141 
Unescaped output detected in HTML passed through variable (notifications.phtml).
ref. #779
@roberto-ebizmarts roberto-ebizmarts pinned this issue Oct 15, 2019
@roberto-ebizmarts roberto-ebizmarts unpinned this issue Oct 15, 2019
roberto-ebizmarts added a commit that referenced this issue Oct 28, 2019
@roberto-ebizmarts
Modifying some some PHP docs in order to throw "Ebizmarts_MailChimp_H…
66f2b45 
…elper_Data_ApiKeyException" properly.

Solving some ref. #779 issues related to 120 characters limit exceeded.
closes #1098
@roberto-ebizmarts roberto-ebizmarts mentioned this issue Oct 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Santiagoebizmarts @ebizmarts-keller @giorello @luciaebizmarts @Juan-ebizmarts