Replacing Mysql4 classes and their uses. closes #1089 #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing unnecessary semicolon: "templateData = {;" in array_dropdown.phtml
…elop' of github.com:mailchimp/mc-magento into Mysql4_classes_are_obsolete_for_M1.6+_#1089 # Conflicts: # app/code/community/Ebizmarts/MailChimp/Helper/Data.php # app/code/community/Ebizmarts/MailChimp/Model/Api/Batches.php # app/code/community/Ebizmarts/MailChimp/Model/Api/Products.php # app/code/community/Ebizmarts/MailChimp/controllers/Adminhtml/MailchimperrorsController.php # shell/getMailchimpResponse.php
Replacing Mysql4 clases to Resource clases from new Ebizmarts/MailChimp/Model/Resource directory. Modifying test classes which uses Mysql4 classes.
roberto-ebizmarts
changed the title
…M1.6+_#1089 # Conflicts: # app/code/community/Ebizmarts/MailChimp/Model/Api/Batches.php
…elop' of github.com:mailchimp/mc-magento into Mysql4_classes_are_obsolete_for_M1.6+_#1089 # Conflicts: # app/code/community/Ebizmarts/MailChimp/Helper/Data.php # app/code/community/Ebizmarts/MailChimp/Model/Api/Batches.php # app/code/community/Ebizmarts/MailChimp/Model/Api/Carts.php # app/code/community/Ebizmarts/MailChimp/Model/Api/Customers.php # app/code/community/Ebizmarts/MailChimp/Model/Api/Orders.php # app/code/community/Ebizmarts/MailChimp/Model/Api/Products.php # app/code/community/Ebizmarts/MailChimp/Model/Api/PromoCodes.php # app/code/community/Ebizmarts/MailChimp/Model/Api/PromoRules.php # dev/tests/mailchimp/tests/app/Ebizmarts/MailChimp/Helper/DataTest.php # dev/tests/mailchimp/tests/app/Ebizmarts/MailChimp/Model/Api/CustomersTest.php # dev/tests/mailchimp/tests/app/Ebizmarts/MailChimp/Model/Api/ProductsTest.php
…_classes_are_obsolete_for_M1.6+_#1089 # Conflicts: # app/code/community/Ebizmarts/MailChimp/Model/Api/Batches.php # dev/tests/mailchimp/tests/app/Ebizmarts/MailChimp/Model/Api/OrdersTest.php
…M1.6+_#1089' into Mysql4_classes_are_obsolete_for_M1.6+_#1089
…_classes_are_obsolete_for_M1.6+_#1089 # Conflicts: # app/code/community/Ebizmarts/MailChimp/Helper/Data.php # app/code/community/Ebizmarts/MailChimp/Model/Api/Batches.php # app/design/adminhtml/default/default/template/ebizmarts/mailchimp/system/config/form/field/array_dropdown.phtml # dev/tests/mailchimp/tests/app/Ebizmarts/MailChimp/Model/Api/OrdersTest.php
…M1.6+_#1089' into Mysql4_classes_are_obsolete_for_M1.6+_#1089
Santiagoebizmarts
approved these changes
Oct 28, 2019
roberto-ebizmarts
deleted the
Mysql4_classes_are_obsolete_for_M1.6+_#1089
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing Mysql4 classes and their uses.
Removing Ebizmarts/MailChimp/Model/Mysql4 directory.
Creating Ebizmarts/MailChimp/Model/Resource directory.
ref. #779
closes #1089