Fix and improve onSuccess/onFailure typings #5787
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The onSuccess type declaration was not consistent with the usage in useDataProvider. Additionally, there was an erroneus definition in the material-ui package.
There were several locations, where the typings were not defined yet for onSuccess and onFailure. useDeclarativeSideEffects and useDataProvider suggested the commited types.
|
As this PR needed rebase and was incomplete, and because I had to write the types to properly understand them, I redid the job in #5853. thanks a lot for your contribution, it put me on the right track! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The onSuccess type declaration was not consistent with the usage in useDataProvider. Additionally, there was an erroneus definition in the material-ui package.
There were several locations, where the typings were not defined yet for onSuccess and onFailure. useDeclarativeSideEffects and useDataProvider suggested the commited types.
Fixes #5761