[TypeScript] Fix onSuccess / onFailure types

[fzaninotto]

Closes #5761
Supersedes #5787

[djhi]

We should probably avoid any in favor of unknow. See #5834

[fzaninotto]

I'm not sure I understand the benefits and shortcomings of any vs unknown. What I've read at https://stackoverflow.com/questions/51439843/unknown-vs-any tells me that there may be drawbacks for end users (like the obligation to perform type checking on an unknown value before using it).

Let's keep the two discussions separate.

[djhi]

There is an eslint warning ;)

[HendrikRoehm]

Additionally, the main fix for #5761 is missing:
OnSuccess should be typed as ({ data } : { data: Record}) => void

[djhi]

@HendrikRoehm:

Additionally, the main fix for #5761 is missing:

No, data is not always a Record. It could be an array of Record for useGetList or anything in the case of custom dataProvider functions

[HendrikRoehm]

@djhi I guess the main problem here is that there exists at least 3 different kind of onSuccess properties, which expect different types, but are all using the same OnSuccess type. Plz check my issue: In the onCreateController, it need to be of the type I have mentioned above. So at least the type there should be changed.

[fzaninotto]

@HendrikRoehm You said:

In the onCreateController, it need to be of the type I have mentioned above

What do you mean? Do you have a compilation error? If so, with which code?

Also, it's only in dataProvider.create() that the onsuccess callback can expect a defined response with a data key.