Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

28 general structure #29

Closed
wants to merge 13 commits into from
Closed

28 general structure #29

wants to merge 13 commits into from

Conversation

qdrn
Copy link
Member

@qdrn qdrn commented May 13, 2023

No description provided.

Adrien added 2 commits May 13, 2023 13:36
@qdrn qdrn requested a review from gregLibert May 13, 2023 22:13
@qdrn qdrn linked an issue May 13, 2023 that may be closed by this pull request
@qdrn
Copy link
Member Author

qdrn commented May 13, 2023

This PR is not meant to be merged but should be viewed as a meta PR for future work.

docs/build/api copy.mdx Outdated Show resolved Hide resolved

# Frontend

TODO: explain how to interact with a smart contract using a frontend through massa-web3 library.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should focus on wallet-provider instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that is still not clear for me is how wallet-provider will be used. Will people be only using wallet-provider in the front end and it will call wallets that are using massa-web3 (or something else) to implement SC calls etc... ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People can:

  • use the wallet provider for classic operations (covered by the wallet standard)
  • use massa-web3 initialized with a wallet-provider for more advanced operations (all operations doable by massa-web3)

This way, a Dapp only needs to focus on wallet provider implementation and a new wallet only needs to focus on the content script part of the wallet provider.


This page should document the available wallets made by Massa Labs or the commmunity.

- Bearby
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even if it's incompatible with wallet-provider and therefor unusable for a dapp?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always possible. Just more work to support more wallet...

sidebars.js Show resolved Hide resolved
docs/learn/architecture.mdx Outdated Show resolved Hide resolved
docs/learn/autonomous-sc.mdx Outdated Show resolved Hide resolved
docs/learn/decentralized-web.mdx Outdated Show resolved Hide resolved
sidebars.js Show resolved Hide resolved
docs/tutorial/home.mdx Outdated Show resolved Hide resolved
},
{
type: "html",
value: "<span class='menu__link'><b><small> Developer Tools </small></b></span>"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also add ercXXX standard (and maybe others)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a proposal. Let me know!

@qdrn qdrn mentioned this pull request Jun 2, 2023
@Ben-Rey Ben-Rey mentioned this pull request Jun 5, 2023
17 tasks
qdrn added a commit that referenced this pull request Jun 5, 2023
qdrn pushed a commit that referenced this pull request Jun 6, 2023
This was referenced Jun 6, 2023
@@ -0,0 +1,8 @@
---
id: massa-station
title: Massa Station
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure to understand why Massa Station is in the wallet part.
The way it is built (however we may want to present and market it differently & i don't mind at all) is that:
Massa Station is a plugin manager Device-app and one of its plug-in: Massa Wallet is a wallet.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This structure is more to be understood a as general guideline, but the specific titles can change, I don't have a strong opinion about them. In this specific case I think it's important to mention the wallet develop with Massa Station under the wallet section.

@qdrn
Copy link
Member Author

qdrn commented Jul 25, 2023

I've closed since most of the structure has been implemented and it starts not being relevant anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

General structure
3 participants