Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add faucet doc #52

Merged
merged 5 commits into from
Jun 6, 2023
Merged

add faucet doc #52

merged 5 commits into from
Jun 6, 2023

Conversation

lilyanB
Copy link
Contributor

@lilyanB lilyanB commented Jun 5, 2023

No description provided.

@lilyanB lilyanB linked an issue Jun 5, 2023 that may be closed by this pull request
network-faucet page #50
Closed
@lilyanB lilyanB requested a review from Ben-Rey June 5, 2023 17:50
@qdrn
Copy link
Member

qdrn commented Jun 5, 2023

I would put the faucet doc in the build section. As was decided here: https://github.com/massalabs/docu-dev/pull/29/files#diff-4d7e57f9b0d680e6756ea5f2117815ad177e0df673cf04cff626b4a34fd1ab11
The node section will quickly be outdated once the testnet is over with mainnet launch and we want to target developers.

qdrn
qdrn reviewed Jun 5, 2023
View reviewed changes
docs/node/faucet.mdx Outdated Show resolved Hide resolved
docs/node/faucet.mdx Outdated Show resolved Hide resolved
@lilyanB lilyanB force-pushed the 50-network-faucet-page branch 2 times, most recently from 2df5c03 to e966502 Compare June 6, 2023 05:46
@lilyanB lilyanB requested a review from qdrn June 6, 2023 05:47
qdrn
qdrn requested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@qdrn qdrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made small changes and made a comment. There is also a conflict to solve. Otherwise it looks ok.

docs/build/faucet.mdx Show resolved Hide resolved
@lilyanB lilyanB requested a review from qdrn June 6, 2023 15:06
@qdrn qdrn merged commit cd1457e into main Jun 6, 2023
@qdrn qdrn deleted the 50-network-faucet-page branch June 6, 2023 23:11
@qdrn
Copy link
Member

qdrn commented Jun 6, 2023 •
edited
Loading

I've fixed the sidebar to follow #29. And made a small change to the intro phrase. Thanks for the work @lilyanB !

@lilyanB lilyanB removed the request for review from Ben-Rey June 7, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qdrn qdrn qdrn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

network-faucet page
2 participants
@lilyanB @qdrn