Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element specific well-known support #3617

Merged
merged 3 commits into from
Jun 28, 2024
Merged

Element specific well-known support #3617

merged 3 commits into from
Jun 28, 2024

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Jun 27, 2024

Handles part of element-hq/element-meta/issues/2441

  • exposes a generic method to make GET requests throgh the SDKs internal HTTP client. This avoids various configuration differences between the SDK stack and that of the client
  • exposes a way to read the server name part of the current user's identifier (already built into ruma, make sense to use it across clients)
  • adds an Element specific well-known struct that the FFI clients can use to deserialize a response JSON

Powers element-hq/element-x-ios#2971

@stefanceriu stefanceriu requested a review from poljar June 27, 2024 07:08
@bnjbvr
Copy link
Member

bnjbvr commented Jun 27, 2024

exposes a generic method to make GET requests throgh the SDKs internal HTTP client. This avoids various configuration differences between the SDK stack and that of the client

I'm a bit curious, what kind of requests are you doing outside the SDK? 👀

@stefanceriu
Copy link
Member Author

I'm a bit curious, what kind of requests are you doing outside the SDK? 👀

Have a look at the linked issue and ElementX PR
tl;dr; fetching Element specific configs from a file

@stefanceriu stefanceriu marked this pull request as ready for review June 28, 2024 08:54
@stefanceriu stefanceriu requested a review from a team as a code owner June 28, 2024 08:54
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.19%. Comparing base (1c92633) to head (d505ad1).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/matrix-sdk/src/client/mod.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3617      +/-   ##
==========================================
+ Coverage   84.17%   84.19%   +0.02%     
==========================================
  Files         255      255              
  Lines       26515    26517       +2     
==========================================
+ Hits        22319    22327       +8     
+ Misses       4196     4190       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is simple enough and fine for now, though we really need to start thinking about a Element specific crate more seriously.

Left a small nit.

bindings/matrix-sdk-ffi/src/element.rs Show resolved Hide resolved
@poljar poljar merged commit 38a18c3 into main Jun 28, 2024
38 checks passed
@poljar poljar deleted the stefan/elementWellKnown branch June 28, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants