Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2713: Remove deprecated v1 Identity Service API #2713

Merged
merged 2 commits into from
Apr 25, 2021

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Jul 30, 2020

@turt2live turt2live changed the title Proposal to remove deprecated identity service endpoints MSC2713: Remove deprecated v1 Identity Service API Jul 30, 2020
@turt2live turt2live added kind:maintenance MSC which clarifies/updates existing spec proposal A matrix spec change proposal proposal-in-review labels Jul 30, 2020
@turt2live
Copy link
Member Author

this doesn't require an implementation, so I vote this jumps straight into the request for comment period:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

mscbot commented Jul 30, 2020

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

Once at least 75% of reviewers approve (and there are no outstanding concerns), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for information about what commands tagged team members can give me.

@mscbot mscbot added disposition-merge proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Jul 30, 2020
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd quite like to see some usage stats from the sydent access logs to help guide us on this.

@turt2live
Copy link
Member Author

I'd quite like to see some usage stats from the sydent access logs to help guide us on this.

Have asked ops, which probably adds even more time for implementations to finally fix themselves.

# MSC2713: Remove deprecated Identity Service endpoints

Implementations will have had plenty of time to adopt the new v2 API for Identity Servers, so
we should clean out the old endpoints.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we do about /_matrix/identity/v2/pubkey/isvalid URLs stored in old m.room.membership events which homeservers MUST verify by making requests to (according to https://matrix.org/docs/spec/client_server/r0.6.1#id102)?

I suppose it's not the end of the world if those third-party invites just don't work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mean the v1 ones? Yes, I would expect that they'd break - servers shouldn't have been issuing v1-routed invites for a while now, so I'm less concerned about invites lost to time.

However, if there are modern invites using the v1 api - fml, we need to fix that.

Copy link
Member

@anoadragon453 anoadragon453 Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Synapse still (partially) does:

{
  "type": "m.room.third_party_invite",
  "sender": "@andrewm:amorgan.xyz",
  "content": {
    "display_name": "h...@g...",
    "public_keys": [
      {
        "key_validity_url": "https://vector.im/_matrix/identity/api/v1/pubkey/isvalid",
        "public_key": "ta8IQ0u1sp44HVpxdFOdS/bfwDjcy4xLFFlfY5KOA"
      },
      {
        "key_validity_url": "https://vector.im/_matrix/identity/api/v1/pubkey/ephemeral/isvalid",
        "public_key": "unYLHHHx_-kYDh9RLh5RvfcTrDgWnNtLdgPC3yM"
      }
    ],
    "key_validity_url": "https://vector.im/_matrix/identity/v2/pubkey/isvalid",
    "public_key": "ta8IQ0u1sp44HVpxYi7dFOdS/bfwDjcy4xLFlfY5KOA"
  },
  "state_key": "HgjJXrYyxxxOtdmyiJHyYRTjMMAiFdDrbCPqyCMdgCSyGMvxsyztxNQHBXMcUOnLjUOdhCMzSzwYEowxPqIYGYcOnXzNMvAlyOKOmnWrnfglNfBAeVfmZLBvQRqDGg",
  "event_id": "$161658804355dhuce:amorgan.xyz",
  "origin_server_ts": 1616588043476,
  "unsigned": {
    "age": 6048
  },
  "room_id": "!xxx:amorgan.xyz"
}

Have recorded on matrix-org/synapse#9677.

@mscbot
Copy link
Collaborator

mscbot commented Apr 20, 2021

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot mscbot added final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. and removed proposed-final-comment-period Currently awaiting signoff of a majority of team members in order to enter the final comment period. labels Apr 20, 2021
@mscbot
Copy link
Collaborator

mscbot commented Apr 25, 2021

The final comment period, with a disposition to merge, as per the review above, is now complete.

@mscbot mscbot added finished-final-comment-period and removed disposition-merge final-comment-period This MSC has entered a final comment period in interest to approval, postpone, or delete in 5 days. labels Apr 25, 2021
@turt2live turt2live merged commit d4bf671 into master Apr 25, 2021
@turt2live turt2live added spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec and removed finished-final-comment-period labels Apr 25, 2021
@turt2live turt2live deleted the travis/msc/remove-v1-identity branch April 27, 2021 15:27
@turt2live turt2live self-assigned this Apr 30, 2021
turt2live added a commit that referenced this pull request May 2, 2021
@turt2live turt2live added spec-pr-in-review A proposal which has been PR'd against the spec and is in review and removed spec-pr-missing Proposal has been implemented and is being used in the wild but hasn't yet been added to the spec labels May 2, 2021
@turt2live
Copy link
Member Author

Merged 🎉

@turt2live turt2live added merged A proposal whose PR has merged into the spec! and removed spec-pr-in-review A proposal which has been PR'd against the spec and is in review labels May 4, 2021
richvdh pushed a commit that referenced this pull request Aug 23, 2021
richvdh pushed a commit that referenced this pull request Aug 23, 2021
richvdh pushed a commit that referenced this pull request Aug 27, 2021
richvdh pushed a commit that referenced this pull request Aug 27, 2021
@richvdh
Copy link
Member

richvdh commented Jul 4, 2022

For links: this was a follow-up to MSC2140, which introduced (most of) the v2 API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:maintenance MSC which clarifies/updates existing spec merged A proposal whose PR has merged into the spec! proposal A matrix spec change proposal
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants