-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove v1 identity service API #3170
Conversation
Spec for #2713
@@ -297,7 +297,7 @@ specify parameter values. The flow for this method is as follows: | |||
6. If the `m.identity_server` property is present, extract the | |||
`base_url` value for use as the base URL of the identity server. | |||
Validation for this URL is done as in the step above, but using | |||
`/_matrix/identity/api/v1` as the endpoint to connect to. If the | |||
`/_matrix/identity/v2` as the endpoint to connect to. If the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not listed in MSC2713, however it seems overly cruel to let MSC2713 remove the endpoint and leave a reference to it in the server discovery. Alternatively, we could disobey MSC2713 slightly and leave the v1 ping endpoint in the spec for now.
Ideally this would have been raised as a concern during MSC review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is actually covered by https://github.com/matrix-org/matrix-doc/pull/2499/files#diff-c7530c5e034a59b498ae6ccaae0289e87d36558ee0c6fee9f0cd3d2c9e52b38fR33.
Changing it here and now does seem like the practical solution, following the spirit if not the letter of MSC2713, so 👍
(we could also see about getting MSC2499 through FCP, to cover all our bases?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, I'll take a look and see what I can do on 2499 to get it moving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Remove v1 identity service API
Remove v1 identity service API
Spec for #2713
Note: Servers are still able to provide this API if they want to. There is no requirement for them to stop serving it.