forked from infernojs/inferno
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from infernojs:master #78
Open
pull
wants to merge
186
commits into
mbchoa:master
Choose a base branch
from
infernojs:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 70e908059d28450ed5ae1edad96fc347767bd168)
… with babel, changed component to be abstract class to indicate it needs to be derived from.
…sed on master) (#1658) * Added tests for inferno-router SSR and <Switch> and fixed a bug. Also added support for subclassing Route * simple lint fixes * Second set of lint-fixes
* Mozilla marked bug as resolved three years ago so the fix should be generally available * Fixed linting errors --------- Co-authored-by: Sampo Kivistö <2021355+Havunen@users.noreply.github.com>
* Add specificity to fix a type error with addEventListener * addEventListener won't accept SemiSyntheticEvent due to extra helper methods, so we need to mark them as optional. * Fix linting error
* adds checking of variable `SKIP_INFERNO_WARNINGS` to skip warnings in non-production mode * `SKIP_INFERNO_WARNINGS` can be also declared globally for browser functionality, or just defined on the process.env in case of node * FYI: JEST related warning skip about development mode was removed with 2ed75dc when fixing #1582, only the skipping of minified code warning was in place
provided style prop is empty object
and converted some inferno-server tests to tsx for Github#1632
A A A A A A A A A A A A F# with '#' will be ignored, and an empty message aborts the commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )