Add compat data for Window sub features from A to F #2109

keshavmesta · 2018-05-22T04:25:15Z

As discussed in #2011

… errors

wbamberg · 2018-05-31T21:02:14Z

It looks to me as if this is missing some items. It includes data for the following:

cancelIdleCallback
clearImmediate
close
convertPointFromNodeToPage
convertPointFromPageToNode
crypto
customElements
devicePixelRatio
dialogArguments
event
frameElement
fullScreen

Looking at the sidebar for Window, I see these properties:

applicationCache
caches*
closed
console
controllers
crypto
customElements
defaultStatus
devicePixelRatio
dialogArguments
directories
document
frameElement
frames
fullScreen

...and these methods:

alert()
atob()*
back()
blur()
btoa()*
cancelAnimationFrame()
cancelIdleCallback()
captureEvents()
clearImmediate()
clearInterval()*
clearTimeout()*
close()
confirm()
convertPointFromNodeToPage()
convertPointFromPageToNode
createImageBitmap()*
dump()
event
fetch()*
find()
focus()
forward()

The ones I put an asterisk * by are part of the WindowOrWorkerGlobalScope interface, so (as I understand it) they are to be omitted from the Window data. But I'm not sure why the rest are missing.

keshavmesta · 2018-06-03T00:09:58Z

@wbamberg yes there is no compat data available for the skipped ones on MDN.

wbamberg · 2018-06-03T17:26:55Z

Thanks for the clarification @keshavmesta :)

wbamberg

Thanks @keshavmesta ! A few comments, but they're all pretty minor :).

wbamberg · 2018-05-23T14:08:21Z

api/Window.json

+            },
+            "ie": {
+              "version_added": true,
+              "notes": "This method is currently only proposed, is not expected to become standard, and is only implemented by recent builds of Internet Explorer."


We should omit this note, since we can capture the same information more effectively by marking it nonstandard in the data.

wbamberg · 2018-05-23T14:08:48Z

api/Window.json

+          },
+          "status": {
+            "experimental": false,
+            "standard_track": true,


We should make this false (i.e. it is not standard)

wbamberg · 2018-06-04T20:20:04Z

api/Window.json

+              "version_added": true
+            },
+            "firefox": {
+              "version_added": true


I'm not sure why this omitted the note: https://developer.mozilla.org/en-US/docs/Web/API/Window/close#Browser_compatibility.

wbamberg · 2018-06-04T20:24:12Z

api/Window.json

+            "opera_android": {
+              "version_added": null
+            },
+            "safari": {


This also omits a note saying that the Safari version is prefixed - we should capure this, but using prefix not a note.

That note also refers to IE, including a link that now redirects to the MDN page :). We should just scrap that part of the note.

wbamberg · 2018-06-04T20:24:30Z

api/Window.json

+              "version_added": null
+            },
+            "safari": {
+              "version_added": true


Same issue as above for convertPointFromNodeToPage.

wbamberg · 2018-06-04T20:33:59Z

api/Window.json

+            },
+            "safari": {
+              "version_added": "4",
+              "notes": "?"


Same comment here, omit this.

wbamberg · 2018-06-04T20:34:09Z

api/Window.json

+            },
+            "firefox": {
+              "version_added": "1",
+              "notes": "1.7 or earlier"


Same comment here, omit this. Use "1" or true.

wbamberg · 2018-06-04T20:34:55Z

api/Window.json

+            },
+            "firefox_android": {
+              "version_added": true,
+              "notes": "1.7 or earlier"


Again, omit this.

wbamberg · 2018-06-04T20:36:39Z

api/Window.json

+          },
+          "status": {
+            "experimental": false,
+            "standard_track": true,


This is not standard according to the page "window.fullScreen is not part of any W3C specification or technical recommendation.".

wbamberg · 2018-06-04T20:37:14Z

api/Window.json

@@ -2595,4 +3112,4 @@
      }
    }
  }
-}
+}


Files should end with a newline.

wbamberg · 2018-06-21T20:21:36Z

I've pushed a commit that (I hope) addresses the review comments I had for this PR. I don't know if it needs an extra review go-round or not :).

Elchi3

This looks good to me now. Thanks @keshavmesta and @wbamberg 👍

keshavmesta · 2018-06-28T21:02:50Z

Thanks @wbamberg for taking care of those review comments 👍

* master: (175 commits) Add Server-Timing header (mdn#2148) 40th alpha version Add compat data for input-password (mdn#2235) Add addTransceiver() method for RTCPeerConnection. (mdn#2311) Update Payments API for Chrome. (mdn#2378) Add compat data for MutationObserver (mdn#2094) Fix compat data for "let" in Chrome (mdn#1632) Safari has more formdata support now (mdn#2376) Add compat data for Window sub features from A to F (mdn#2109) Add guidelines around worker support and constructors for API subfeatures (mdn#2373) Update place-content.json (mdn#2240) Add compat data for HTMLDetailsElement (mdn#2315) Add compat data for input-month (mdn#2204) Add compat data to input-week (mdn#2230) Add compat data for input-radio (mdn#2208) Add compat data for input-tel (mdn#2226) Add compat data for input-image (mdn#2207) Add compat data for input-number (mdn#2206) Add compat data for input-hidden (mdn#2203) Add compat data for input-file (mdn#2202) ...

keshavmesta added 11 commits May 15, 2018 23:56

Add compt info for Window sub features | part 1

38abe3b

Add compt info for Window sub features | part 1

ab39b6f

Merge branch 'feature/window' of https://github.com/keshavmesta/brows…

58ecfca

…er-compat-data into feature/window

Add compat info for Window sub features | A to L covered

e70055d

Add compt info for Window sub features | part 1

8e29ce3

Add compat info for Window sub features | A to L covered

9173cde

Merge branch 'feature/window' of https://github.com/keshavmesta/brows…

3fbe199

…er-compat-data into feature/window

Group multiple rows as sub features of sub features; Resolve npm test…

535a9d2

… errors

Merge branch 'master' into feature/window

45bb9ec

Merge branch 'master' into feature/window

ac5be72

Manual merge from master branch

43f72b0

keshavmesta mentioned this pull request May 22, 2018

Migrate the Window interface #2011

Closed

Elchi3 added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 22, 2018

Elchi3 added this to the Q2 Sprint 3 milestone May 22, 2018

wbamberg self-requested a review May 23, 2018 00:22

Elchi3 modified the milestones: Sprint 3 Q2 2018, Sprint 4 Q2 2018 May 30, 2018

wbamberg requested changes Jun 4, 2018

View reviewed changes

Fix review comments

d987f73

Elchi3 approved these changes Jun 27, 2018

View reviewed changes

Elchi3 merged commit bc5c607 into mdn:master Jun 27, 2018

GPHemsley mentioned this pull request Jan 3, 2022

window.event Fyrd/caniuse#2432

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add compat data for Window sub features from A to F #2109

Add compat data for Window sub features from A to F #2109

keshavmesta commented May 22, 2018 •

edited

Loading

wbamberg commented May 31, 2018

keshavmesta commented Jun 3, 2018

wbamberg commented Jun 3, 2018

wbamberg left a comment

wbamberg May 23, 2018

wbamberg May 23, 2018

wbamberg Jun 4, 2018

wbamberg Jun 4, 2018

wbamberg Jun 4, 2018

wbamberg Jun 4, 2018

wbamberg Jun 4, 2018

wbamberg Jun 4, 2018

wbamberg Jun 4, 2018

wbamberg Jun 4, 2018

wbamberg commented Jun 21, 2018

Elchi3 left a comment

keshavmesta commented Jun 28, 2018

@@ @@ -2595,4 +3112,4 @@ @@
                     }
                   }
                 }
-              }
+              }

Add compat data for Window sub features from A to F #2109

Add compat data for Window sub features from A to F #2109

Conversation

keshavmesta commented May 22, 2018 • edited Loading

wbamberg commented May 31, 2018

keshavmesta commented Jun 3, 2018

wbamberg commented Jun 3, 2018

wbamberg left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wbamberg commented Jun 21, 2018

Elchi3 left a comment

Choose a reason for hiding this comment

keshavmesta commented Jun 28, 2018

keshavmesta commented May 22, 2018 •

edited

Loading