Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compat data for Window sub features from A to F #2109

Merged
merged 12 commits into from
Jun 27, 2018
Merged

Add compat data for Window sub features from A to F #2109

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
38abe3b
Add compt info for Window sub features | part 1
keshavmesta May 16, 2018
ab39b6f
Add compt info for Window sub features | part 1
keshavmesta May 16, 2018
58ecfca
Merge branch 'feature/window' of https://github.com/keshavmesta/brows…
keshavmesta May 16, 2018
e70055d
Add compat info for Window sub features | A to L covered
keshavmesta May 20, 2018
8e29ce3
Add compt info for Window sub features | part 1
keshavmesta May 16, 2018
9173cde
Add compat info for Window sub features | A to L covered
keshavmesta May 20, 2018
3fbe199
Merge branch 'feature/window' of https://github.com/keshavmesta/brows…
keshavmesta May 20, 2018
535a9d2
Group multiple rows as sub features of sub features; Resolve npm test…
keshavmesta May 20, 2018
45bb9ec
Merge branch 'master' into feature/window
keshavmesta May 22, 2018
ac5be72
Merge branch 'master' into feature/window
keshavmesta May 22, 2018
43f72b0
Manual merge from master branch
keshavmesta May 22, 2018
d987f73
Fix review comments
Jun 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix review comments
  • Loading branch information
Will Bamberg committed Jun 21, 2018
commit d987f73bd4bfcf028e8eb14f3d7196dc09510e49
50 changes: 26 additions & 24 deletions api/Window.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,7 @@
"version_added": false
},
"ie": {
"version_added": true,
"notes": "This method is currently only proposed, is not expected to become standard, and is only implemented by recent builds of Internet Explorer."
"version_added": true
},
"opera": {
"version_added": false
Expand All @@ -172,7 +171,7 @@
},
"status": {
"experimental": false,
"standard_track": true,
"standard_track": false,
"deprecated": false
}
}
Expand All @@ -194,10 +193,16 @@
"version_added": true
},
"firefox": {
"version_added": true
"version_added": true,
"notes": [
"Starting in Firefox 46.0.1, <code>Window.close()</code> can no longer close windows that weren't opened by the same script. This is a security precaution."
]
},
"firefox_android": {
"version_added": true
"version_added": true,
"notes": [
"Starting in Firefox 46.0.1, <code>Window.close()</code> can no longer close windows that weren't opened by the same script. This is a security precaution."
]
},
"ie": {
"version_added": true
Expand Down Expand Up @@ -260,7 +265,8 @@
"version_added": null
},
"safari": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also omits a note saying that the Safari version is prefixed - we should capure this, but using prefix not a note.

That note also refers to IE, including a link that now redirects to the MDN page :). We should just scrap that part of the note.

"version_added": true
"version_added": true,
"alternative_name": "webkitConvertPointFromNodeToPage"
},
"safari_ios": {
"version_added": true
Expand Down Expand Up @@ -311,7 +317,8 @@
"version_added": null
},
"safari": {
"version_added": true
"version_added": true,
"alternative_name": "webkitConvertPointFromPageToNode"
},
"safari_ios": {
"version_added": true
Expand Down Expand Up @@ -353,7 +360,8 @@
"version_added": true
},
"ie": {
"version_added": "11"
"version_added": "11",
"prefix": "ms"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefixed in IE according to the table in the page.

"opera": {
"version_added": "19"
Expand Down Expand Up @@ -501,7 +509,7 @@
"version_added": true
},
"firefox": {
"version_added": true
"version_added": "49"
},
"firefox_android": {
"version_added": null
Expand Down Expand Up @@ -606,7 +614,7 @@
"version_added": null
},
"firefox_android": {
"version_added": true
"version_added": null
},
"ie": {
"version_added": true
Expand Down Expand Up @@ -642,8 +650,7 @@
"mdn_url": "https://developer.mozilla.org/docs/Web/API/Window/frameElement",
"support": {
"chrome": {
"version_added": "4",
"notes": "?"
"version_added": true
},
"chrome_android": {
"version_added": null
Expand All @@ -655,27 +662,22 @@
"version_added": true
},
"firefox": {
"version_added": "1",
"notes": "1.7 or earlier"
"version_added": "1"
},
"firefox_android": {
"version_added": true,
"notes": "1.7 or earlier"
"version_added": true
},
"ie": {
"version_added": "5.5",
"notes": "?"
"version_added": true
},
"opera": {
"version_added": "12.1",
"notes": "?"
"version_added": true
},
"opera_android": {
"version_added": null
},
"safari": {
"version_added": "4",
"notes": "?"
"version_added": true
},
"safari_ios": {
"version_added": null
Expand Down Expand Up @@ -740,7 +742,7 @@
},
"status": {
"experimental": false,
"standard_track": true,
"standard_track": false,
"deprecated": false
}
}
Expand Down Expand Up @@ -3112,4 +3114,4 @@
}
}
}
}
}